Merge two similar strings. #11708
Merged
Merge two similar strings. #11708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
My vote would be for sentence case. |
ocean90
added
[Feature] Blocks
|
Good catch -- tooltips like this should be sentence case. |
|
Then we should also review toolbar tooltips in other blocks (like I mentioned, already saw Edit Gallery and Edit Table). |
|
@dimadin can we update the other one as discussed? :) |
|
@gziolo Done. Should we also change instances I mentioned above, or that can wait? |
|
Yes, please as it was already raised and is similar to the change you are about to introduce 👍 |
|
New pull request or this one?
|
gziolo
approved these changes
Nov 22, 2018
youknowriad
pushed a commit
that referenced
this pull request
Nov 29, 2018
* Merge two similar strings. * Use sentence case for "Edit Media" toolbar tooltip.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two tooltips of the same toolbar icons that differ only in capitalization of second word.
This PR uses Title Case for both, however, I am not sure what case should be used because it's inconsistent. Other icons use Sentence case, but this pencil icon (Edit) uses both Title Case (Edit Gallery, Edit Table) and Sentence case (Edit image).