Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Components: Restore click-to-close behavior of Dropdown toggle #11633

Merged
merged 5 commits into from
Nov 8, 2018

Conversation

aduth
Copy link
Member

@aduth aduth commented Nov 8, 2018

Partially addresses #11579
Regression introduced in #11253
Effectively reverts 58725c4

This pull request seeks to resolve a regression where clicking a Dropdown toggle button while the Dropdown's Popover is already opened results in the Popover remaining opened.

Testing instructions:

Verify that clicking a Dropdown toggle button while the Popover is visible results in the popover being hidden.

  1. Navigate to Posts > Add New
  2. Click the More Menu button in the top-right
  3. Click the More Menu button in the top-right, again
  4. Note that the Popover is now closed.

Ensure end-to-end tests pass:

npm run test-e2e test/e2e/specs/popovers.test.js

@aduth aduth added [Feature] UI Components Impacts or related to the UI component system [Type] Regression Related to a regression in the latest release labels Nov 8, 2018
@aduth aduth added this to the 4.3 milestone Nov 8, 2018
Copy link
Member

@notnownikki notnownikki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works well for me 👍

@oandregal oandregal self-requested a review November 8, 2018 16:44
@aduth aduth merged commit a0d0e1a into master Nov 8, 2018
@aduth aduth deleted the fix/click-dropdown-toggle branch November 8, 2018 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] UI Components Impacts or related to the UI component system [Type] Regression Related to a regression in the latest release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants