Update/1038 freeform block add more drawer #1153
Conversation
|
I have updated the more-drawer to add the arrow in the mockup and to handle the sticky behaviour better. When there is sufficient space it displays above. But if you scroll down and it can't fit then it displays below. |
| break; | ||
| } | ||
| blockControls = blockControls.parentElement; | ||
| } |
There was a problem hiding this comment.
What element are we trying to get here? Could we use element.closest() instead of looping like this (We just need to include the polyfill import 'element-closest';?
There was a problem hiding this comment.
I considered element.closest() but dismissed it because IE does not support it. I didn't know that the polyfill was available.
There was a problem hiding this comment.
I have updated to use the polyfill.
| <Toolbar controls={ this.mapControls( MORE_CONTROLS ) } /> | ||
| </div> | ||
| ), | ||
| } ) } |
There was a problem hiding this comment.
Should we consolidate the two <BlockControls> usage and the <Fill name="Formatting.Toolbar"> into a unique <BlockControls>?
Something like
<BlockControls>
<Toolbar />
<Toolbar />
<Toolbar />
</BlockControls>There was a problem hiding this comment.
That would make things much cleaner. It should probably be done as a separate pull request though.
There was a problem hiding this comment.
Nevermind, I see how it can be done now - I had assumed that the controls prop were the only way to set the content of the element.
Previously I was using multiple calls to BlockControls using the controls prop.
Added a rule to allow the toolbar css to apply to inline toolbars Added a rule to fix colour of button text (ie subscript) when hovered
This pull request adds the ability of toolbar items to have children (which allows menus) and it uses this to implement a basic more-drawer (aka kitchen sink, aka ellipse menu) for the freeform block.
Still to do:
Add arrow pointing to ellipse button as in mockup (Freeform Block: Add "Kitchen Sink" #1038 )Fix scrolling behaviour so it does not go offscreen