Docs: clarify isDefault usage for registerBlockStyles()

[ajitbohra]

Removes isDefault info for registerBlockStyle() from handbook.

Clarify isDefault usage for registerBlockStyles()

Reference #11451

[tofumatt]

Hi @ajitbohra, thanks for the PR. In the future, feel free to assign more folks than just @chrisvanpatten and I to review documentation PRs. It's probably best to assign the review to gutenberg-core, so that a wider group of people can see the review request 😄

[tofumatt]

I can't tell from the issue if there is a bug here or not; in the issue it seems like @dgwyer is saying this should work. So I don't think removing the docs is the right approach.

[dgwyer]

I think it makes sense to have the isDefault property in registerBlockStyle() override the default style variation that may have been set in the blocks registerBlockType() function.

The issue is that isDefault appears to be ignored when used in registerBlockStyle().

[tofumatt]

Yeah, that makes sense to me too.

[youknowriad]

I think people are confusing "isDefault" as the default style variation applied when you insert the block (concept we don't have at the moment). That's not what the current "isDefault" refer to. The current "isDefault" is used to give a name to the style variation that doesn't add any custom className. (The no-style style variation).

[ajitbohra]

@tofumatt noted agree with you on that

@youknowriad yes currently it's confusing if I am not wrong its kind of fallback style in case of missing style variation?

Instead of removing we need copy update for the isDefault

[dgwyer]

@youknowriad I think I'm more confused now than when I started. Here's what I found after more testing.

It appears that when isDefault is used inside registerBlockStyle() it's recognized ONLY if no styles in registerBlockType() have been set as the default. Otherwise isDefault is always ignored inside of registerBlockStyle().

Also, even if a style variation is selected in the block UI on insertion no CSS class is actually applied to the block wrapper element until a style variation option is manually clicked.

This feels counter intuitive to me. I'd expect the style variation CSS class to be applied whenever one is selected, either on block insertion or manual selection. This isn't currently the case.

And allowing registerBlockStyle() to override the default style variation defined in registerBlockStyle() would make a lot of sense.

[youknowriad]

@dgwyer yes, at the moment isDefault is just used to give a name the "no class" style variation. It's not meant to solve the style variation selected when you inserter the block use-case, this "concept" doesn't exist yet.

[gziolo]

@ajitbohra can you clarify the intent of isDefault instead of removing this line based on this comment from @youknowriad:

The current "isDefault" is used to give a name to the style variation that doesn't add any custom className. (The no-style style variation).

[ajitbohra]

@gziolo PR updated to clarify the usage of isDefault

[gziolo]

@youknowriad - is it correct now?

[youknowriad]

Maybe something like?

By adding isDefault: true you can mark the registered style variation as the one that is active without any custom className.

(Or something in that vein, it's hard to explain :P)

[gziolo]

Haha, so @ajitbohra couldn't approve. Let me do it on his behalf as I authored the last version. Thanks for good teamwork on this one 💯