Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert mobile RN testsuite integration #11318

Merged
merged 2 commits into from
Oct 31, 2018

Conversation

hypest
Copy link
Contributor

@hypest hypest commented Oct 31, 2018

Description

Removes the native mobile testsuite integration.

With the Gutenberg rollout around the corner, people are busy and the native mobile testsuite integration has been left unattended and without evolution. Not many people feel comfortable touching the related feature anyway, and that makes finding resources to work on it even harder.

As a stop gap solution until we have a better integration and coordination between the stakeholders, this PR removes the native mobile testsuite as whole.

Some parallel approaches to this one in these PRs:

How has this been tested?

  • npm install, npm test work fine without pulling in any native mobile code
  • Travis on this PR is green

Types of changes

Checklist:

  • My code is tested.
  • My code follows the WordPress code style.
  • My code follows the accessibility standards.
  • My code has proper inline documentation.

@hypest hypest added the Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change) label Oct 31, 2018
@hypest hypest requested review from a team and youknowriad October 31, 2018 16:35
@aduth
Copy link
Member

aduth commented Oct 31, 2018

Reverts #9883

Copy link
Member

@aduth aduth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@aduth aduth merged commit 29f209a into master Oct 31, 2018
@aduth aduth deleted the rnmobile/revert-mobile-rn-testsuite-integration branch October 31, 2018 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Mobile App - i.e. Android or iOS Native mobile impl of the block editor. (Note: used in scripts, ping mobile folks to change)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants