Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Extends docs for withFilters HOC #11312

Closed
wants to merge 1 commit into from
Closed

Docs: Extends docs for withFilters HOC #11312

wants to merge 1 commit into from

Conversation

gziolo
Copy link
Member

@gziolo gziolo commented Oct 31, 2018

Description

Supersedes #10195. This PR extends documentation for the withFIlters higher-order component (HOC). It improves the code and tries to make it easier to read. It also adds an example where props can be overridden.

@gziolo gziolo added [Type] Developer Documentation Documentation for developers [Feature] Extensibility The ability to extend blocks or the editing experience labels Oct 31, 2018
@gziolo gziolo added this to the 4.3 milestone Oct 31, 2018
@gziolo gziolo closed this Oct 31, 2018
@gziolo gziolo deleted the update/docs-with-filters branch October 31, 2018 15:27
@gziolo gziolo removed this from the 4.3 milestone Oct 31, 2018
@gziolo
Copy link
Member Author

gziolo commented Oct 31, 2018

I will try again with #1313...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajitbohra ajitbohra Awaiting requested review from ajitbohra

@chrisvanpatten chrisvanpatten Awaiting requested review from chrisvanpatten

@adamsilverstein adamsilverstein Awaiting requested review from adamsilverstein

Assignees
No one assigned
Labels
[Feature] Extensibility The ability to extend blocks or the editing experience [Type] Developer Documentation Documentation for developers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gziolo