Paste: detect single line and treat as inline text #10614
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcsf
approved these changes
Oct 15, 2018
|
|
||
| // If we're allowed to return inline content and there is only one block | ||
| // and the original plain text content does not have any line breaks, then | ||
| // treat it as inline paste. |
There was a problem hiding this comment.
This seems to be a good set of conditions to have in general, even regardless of the very specific issue this is targeting. I'm racking my brains for any unintended consequences this may have.
| expect( console ).toHaveLogged(); | ||
| } ); | ||
|
|
||
| it( 'should parse Markdown with HTML', () => { | ||
| const filtered = rawHandler( { | ||
| HTML: '', | ||
| plainText: '# Some <em>heading</em>', | ||
| plainText: '# Some <em>heading</em>\n\nA paragraph.', |
There was a problem hiding this comment.
Because this specific test tests Markdown parsing, which together with this PR would only result into a heading if there's multiple lines paste.
|
This is a great small change, thanks. |
|
Please add the ability (sometime down the road...:) to select between bullets and other kinds of icons. For instance numbers, stars etc. Thanks. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes #6555.
If the pasted content results in one block, and the plain text version has no line breaks, then paste as inline text if
modeis set toAUTO.This PR is block agnostic compared to #5354, because it checks the original plain text.
How has this been tested?
See #6555 and #5354.
Screenshots
Types of changes
Checklist: