Fix button block regressions #10565
Fix button block regressions #10565
Conversation
The button block regressed as part of a few changes recently, including one to increase placeholder text contrast. This PR fixes that.
jasmussen
added
the
[Type] Regression
There was a problem hiding this comment.
Gave this a test, and it seems to improve things immeasurably, so probably an important one to merge.
It does look like this is the first time we've added styles specifically for the style variation preview, which is probably the only controversial bit in this PR:
https://github.com/WordPress/gutenberg/pull/10565/files#diff-48774fc728094a4cbd45abc1d467ee70R35
| opacity: 0.8; | ||
| } | ||
|
|
||
| // Don't let the placeholder text wrap in the variation preview. | ||
| .editor-block-styles__item-preview & { |
There was a problem hiding this comment.
I think this should be .editor-block-preview__content because it the preview component can be used in several places.
|
There is some issue with
It might be a feature, just wanted to make sure it works properly. Otherwise it's ready to go. |
|
Okey, it's better than in |
The button block regressed as part of a few changes recently, including one to increase placeholder text contrast.
This PR fixes that.
It also fixes an issue where the text on the outline button version was white.
Before:
After: