[RN mobile] fix className style in SVG primitive #10556
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As explained in #9294 (comment), commits 2d47451 and b678c6d introduced a change that makes sure to convert a string
className
value to astyle
object for ReactNative to work properly without needing to strip theclassName
altogether (and thus losing any intended modifiers, as is currently being done inmaster
).These commits were removed somehow after introducing #9685 and applying the "older" #9294 after it, so this PR only brings this change back as originally intended.
How has this been tested?
To test how this works:
to
packages/components/src/dashicon/style.scss
This way the styles get passed to the svg component, this is how the bold icon gets rendered:
Verify the B icon is slightly (20 degrees) leaning to the right as seen in the screenshot
Types of changes
Bug fix
Checklist: