Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block audit: Verse #8336

Closed
sarahmonster opened this issue Jul 31, 2018 · 2 comments · Fixed by #19355
Closed

Block audit: Verse #8336

sarahmonster opened this issue Jul 31, 2018 · 2 comments · Fixed by #19355
Assignees
Labels
[Feature] Blocks Overall functionality of blocks [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take

Comments

@sarahmonster
Copy link
Member

sarahmonster commented Jul 31, 2018

Note: We'll be doing these audits in waves and editing this as we work through the blocks, so this text will be updated and fleshed out as we progress. See the full picture here.

Overview

screenshot 2018-07-31 20 34 31

Name: Verse
Description: A block for haiku? Why not? Blocks for all the things! (See what we did here?)
Category: Formatting
CSS class: wp-block-verse in frontend and editor
Can be converted to: paragraph

States

Empty:
screenshot 2018-07-31 20 30 27

Selected:
screenshot 2018-07-31 20 18 19

Unselected:
screenshot 2018-07-31 20 29 58

Placeholder:
screenshot 2018-07-31 20 30 19

Primary (toolbar) settings

Align left, centre, right, bold, italic, strikethrough

Secondary (sidebar) settings

Advanced: Additional CSS Class

Frontend appearance

Gutenberg starter theme:

Atomic Blocks

twentyseventeen:

twentyten:

Documentation

No devdocs in https://github.com/WordPress/gutenberg/tree/master/core-blocks/verse

Suggestion for user-facing docs:

Performance on mobile

Accessibility

Bugs/errors

Individual issues will be opened for these soon

Suggestions

Individual issues will be opened for these soon

  1. This one makes me even more confused about what the preformatted block is for.

  2. Placeholder doesn't fit with other placeholders, stylistically.

  3. Should there be an option for a link in there as well, for consistency with other text blocks?

  4. Why call it "Verse" instead of "Poem"? The latter seems more descriptive.

  5. The slash inserter pops up a verse block if you type "poetry", but not if you type "poem".

  6. Not sure the pencil icon best represents this block. The pencil represents an action, whereas most of the block icons represent a visual abstraction of the actual block's appearance.

  7. In a lot of themes, preformatted and verse blocks look exactly the same. (This is because they both use the pre element, and neither ships with default styles.)

@sarahmonster sarahmonster self-assigned this Jul 31, 2018
@sarahmonster sarahmonster added [Type] Task Issues or PRs that have been broken down into an individual action to take [Feature] Blocks Overall functionality of blocks labels Jul 31, 2018
@ZebulanStanphill
Copy link
Member

Why call it "Verse" instead of "Poem"? The latter seems more descriptive.

Well, song lyrics fit this block as well, and both songs and poems have verses, hence the name, I guess.

Also, ideally the Verse block would indent soft new lines but not hard new lines. That is not actually the case right now, though. See the discussion in #4138. That would be a difference in behavior from the Preformatted block. Additionally, you probably do not want your poetry or song lyrics to use a monospace font, which is another reason this is separate from the Preformatted block. Different semantic meaning and implied styling/behavior.

@melchoyce
Copy link
Contributor

We should look at replacing the block icon with a feather/quill icon.

@mtias mtias added the Needs Design Needs design efforts. label Nov 17, 2019
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Dec 28, 2019
@mapk mapk removed the Needs Design Needs design efforts. label Dec 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Status] In Progress Tracking issues with work in progress [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants