Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typewriter Experience doesn't work when Custom Fields are shown #61210

Closed
jsit opened this issue Apr 29, 2024 · 9 comments
Closed

Typewriter Experience doesn't work when Custom Fields are shown #61210

jsit opened this issue Apr 29, 2024 · 9 comments
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... Needs Testing Needs further testing to be confirmed. [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Bug An existing feature does not function as intended

Comments

@jsit
Copy link

jsit commented Apr 29, 2024

Description

When the Custom Fields panel is shown, the Typewriter Experience / Typewriter Scrolling (#16460) doesn't work.

Step-by-step reproduction instructions

  1. In Editor Preferences on the Edit page, enable "Custom fields"
  2. Save pref and reload the page
  3. See that cursor is able to reach the bottom of the editor window, and can't be scrolled past

Screenshots, screen recording, code snippet

No response

Environment info

  • WordPress 6.5.2
  • Gutenberg version...unsure? Whatever is bundled with WP 6.5.2

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@jsit jsit added the [Type] Bug An existing feature does not function as intended label Apr 29, 2024
@jordesign jordesign added [Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... Needs Testing Needs further testing to be confirmed. labels Apr 30, 2024
@jhimross
Copy link

@jsit I am not sure if there's an issue here. I tried replicating the issue by following the instructions you provided above.
I attempted to replicate the issue using WP 6.5.2, the Twenty Twenty-Four theme, and no other plugins installed.

I enabled the Custom Fields, and this is what I see. Watch: https://share.zight.com/JruE7ePK

No issues were experienced. The typewriter experience still works as expected and can be scrolled.

Could you please provide more details to replicate the issue, or if possible, provide a screenshot or screen recording?

@jsit
Copy link
Author

jsit commented May 10, 2024

@jhimross Hm, I don't know what we are doing differently. This screen recording was taken on a WP 6.5.3 install, with the Twenty Twenty-Four theme, and no active plugins:

https://www.dropbox.com/scl/fi/usy2nhrdube8109brmsxk/Screen-Recording-2024-05-10-at-12.51.53-PM.mov?rlkey=6d5cwhzdwd91gem1k6r6y4z1y&e=1&st=eoaois5o&dl=0

This is in Safari, but I see the same issue in Chrome.

@jhimross
Copy link

Tried replicating the issue again using WP 6.5.3, Twenty Twenty Four theme, and no active plugins. But I still can't replicate it using different browsers.

This is what's happening when using:
Chrome and Edge in Windows:- https://share.zight.com/2Nu8rnWm
Using Safari 17.3 :- https://share.zight.com/mXuWmwvX

@jsit
Copy link
Author

jsit commented May 11, 2024

What you are showing in the first video is what I’m describing. When you scroll down with no Custom Fields, there is a lot of space between the final block and the bottom of the input area; you can be in the final block and be typing in the “middle” of the window. You can’t do this if Custom Fields are shown.

@jsit
Copy link
Author

jsit commented Jun 7, 2024

@jhimross Do you need more details from me, or does what I'm saying make sense?

Copy link

github-actions bot commented Jul 8, 2024

Hi,
This issue has gone 30 days without any activity. This means it is time for a check-in to make sure it is still relevant. If you are still experiencing this issue with the latest versions, you can help the project by responding to confirm the problem and by providing any updated reproduction steps.
Thanks for helping out.

@github-actions github-actions bot added the [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. label Jul 8, 2024
@t-hamano
Copy link
Contributor

When you scroll down with no Custom Fields, there is a lot of space between the final block and the bottom of the input area; you can be in the final block and be typing in the “middle” of the window. You can’t do this if Custom Fields are shown.

This is true. The underlying issue stems from the fact that the editor content is no longer an iframe when a meta box is present.

The following PRs are likely relevant to solve this issue:

@stokesman
Copy link
Contributor

I’ll close this as #64639 is merged and should resolve it. Please reopen if I'm mistaken.

@jsit
Copy link
Author

jsit commented Aug 23, 2024

@stokesman Amazing, thank you! Very exciting.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Writing Flow Block selection, navigation, splitting, merging, deletion... Needs Testing Needs further testing to be confirmed. [Status] Stale Gives the original author opportunity to update before closing. Can be reopened as needed. [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants