-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Standardize link text and URL terminology across the editor #59993
Comments
Some of the relevant files to be checked:
|
I had this queued up to write an issue for as well. Yes, we should tweak this.
Yes, "Text" and "Link" feel appropriate to me. We could potentially do the same for the social links as well: #60047. Perhaps one day it uses LinkControl as well even. |
I don't think it's sufficient.
Screenshots of the block inspector cards with various link-related blocks, to illustrate the term 'Text' doesn't clarify sufficiently what the input field is about: Placeholder text of the navigation items still says 'Add llabel...': Reopening to allow for broader discussion. |
Yep, that 'Navigation Label' in the classic menus is pretty old. It's inconsistent with custom links and also a little weird to translate. Also, it shouldn't be title case. Not sure changing such an old UI is worth it but, in case, I'd change it to 'Link text'. Re: the term URL I'm not sure I have strong opinions.
|
Regarding the inline link, I would like to provide two more examples outside of WordPress. Notion: "Page or URL" and "Link title" Slack: "Text" and "Link" (This is consistent with the changes made in #60116) To be honest, I'm also wondering which is the correct answer in WordPress 😅 |
Link text is fine in that particular context, but if we do what I suggested—to bring the link field there as well—then "Text" and "Link" would work great there as well. "Link text" and "Link" adds more words with not enough benefit for the increased word count.
Agreed. "URL" is a technical term—I'd avoid using terminology that requires additional understanding.
This should be "Link" (no ellipsis) — to follow suite of other placeholder text. |
Hey I wanted to work on the same. Kindly assign me this @afercia |
@Niyatijain-9 thanks for willing to work on this. You don't need to be assigned to an issue to work and submit a PR. |
Hello! I came across this issue and found it interesting. Is this still open to work on? |
I think #60116 took care of this but failed to properly reference this issue to close it. |
Description
Links and navigation links / submenus can be edited in the editor via a few components.
Although these user interfaces come from different components, the terminology should be consistend when it comes to:
RIght now, the names of these fields are different and don't contribute to UI clarity, especially when they can be displayed at the same time under the eyes of the users.
I'd vote for what makes most sense for users and I'd think the most familiar terminology for users is text / link.
Regardless, the UI should use the same terminology everywhere.
Screenshot when editing a page link in a navigation:
Screenshot when editing a custom link in a navigation:
The same applies to navigation submenus.
Step-by-step reproduction instructions
Screenshots, screen recording, code snippet
No response
Environment info
No response
Please confirm that you have searched existing issues in the repo.
Yes
Please confirm that you have tested with all plugins deactivated except Gutenberg.
Yes
The text was updated successfully, but these errors were encountered: