Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Font Library: Unintended border appears when font is not present #56734

Closed
t-hamano opened this issue Dec 2, 2023 · 1 comment
Closed

Font Library: Unintended border appears when font is not present #56734

t-hamano opened this issue Dec 2, 2023 · 1 comment
Labels
[Feature] Typography Font and typography-related issues and PRs Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended

Comments

@t-hamano
Copy link
Contributor

t-hamano commented Dec 2, 2023

Description

The Global Style Typography panel displays an unnatural border when the theme does not define a font.

fonts-border

I'm wondering if it would be a good idea to display a copy like below if the font doesn't exist.

fonts-suggest

This is similar to the UI when there is no custom color palette.

palette-edit

Step-by-step reproduction instructions

  • Enable EmptyTheme. This theme does not define any fonts.
  • Open the site editor and access the Global Styles Typography panel.
  • You should now see a border in the Fonts section.

Screenshots, screen recording, code snippet

No response

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes
@t-hamano t-hamano added [Type] Bug An existing feature does not function as intended Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Feature] Typography Font and typography-related issues and PRs labels Dec 2, 2023
inc2734 added a commit to inc2734/gutenberg that referenced this issue Dec 6, 2023
@inc2734
WordPress#56734 When there is no font, the border should not appear. …
1e980e9 
…Display further guidance text.
@inc2734 inc2734 mentioned this issue Dec 6, 2023
Merged
@t-hamano
Copy link
Contributor Author

I mark this issue as a duplicate as I myself reported the exact same issue in #54527 😅

@t-hamano t-hamano closed this as not planned Won't fix, can't repro, duplicate, stale Dec 27, 2023
t-hamano pushed a commit that referenced this issue Jan 11, 2024
@inc2734 @matiasbenedetto @mikachan
Display guidance text when there is no font (#56825)
ea90b75 
* #56734 When there is no font, the border should not appear. Display further guidance text.

* update text

* Fix formatting in font-families.js

* Improve readability

---------

Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com>
Co-authored-by: Sarah Norris <sarah@sekai.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
[Feature] Typography Font and typography-related issues and PRs Global Styles Anything related to the broader Global Styles efforts, including Styles Engine and theme.json [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@t-hamano