Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Loading a Classic block when visual editor is disabled in user profile #5667

Closed
mtias opened this issue Mar 16, 2018 · 1 comment · Fixed by #5670
Closed

Loading a Classic block when visual editor is disabled in user profile #5667

mtias opened this issue Mar 16, 2018 · 1 comment · Fixed by #5670
Assignees
@mcsf
Labels
Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended

Comments

@mtias
Copy link
Member

mtias commented Mar 16, 2018

If a user has the "disable visual editor" setting checked in their profile, loading a Classic blocks breaks the editor with: Uncaught module [5] returned undefined in TinyMCE's theme.min. This is not trivial to debug for the user as they are just greeted with a blank page when loading an old post.
@mtias mtias added [Type] Bug An existing feature does not function as intended [Component] TinyMCE Needs Design Feedback Needs general design feedback. labels Mar 16, 2018
@mcsf mcsf self-assigned this Mar 16, 2018
@mcsf mcsf mentioned this issue Mar 16, 2018
Merged
3 tasks
mcsf added a commit that referenced this issue Mar 16, 2018
@mcsf
Ignore "Disable visual editor" setting
e75be7a 
Fixes #5667

See wp-includes/class-wp-editor's behavior around self::$this_tinymce:
https://github.com/WordPress/WordPress/blob/176a28905041fd79c439946a4ba290a87db5991f/wp-includes/class-wp-editor.php#L360
@bobbingwide
Copy link
Contributor

Related issue #4634

mtias pushed a commit that referenced this issue Mar 20, 2018
@mcsf @mtias
Ignore "Disable visual editor" setting (#5670)
1f1f49d 
Fixes #5667

See wp-includes/class-wp-editor's behavior around self::$this_tinymce:
https://github.com/WordPress/WordPress/blob/176a28905041fd79c439946a4ba290a87db5991f/wp-includes/class-wp-editor.php#L360
This was referenced Jan 29, 2019
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mcsf mcsf

Labels
Needs Design Feedback Needs general design feedback. [Type] Bug An existing feature does not function as intended
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Ignore "Disable visual editor" setting WordPress/gutenberg
3 participants
@mcsf @mtias @bobbingwide