Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Social Links Block: update Twitter Logo #53223

Closed
jeherve opened this issue Aug 1, 2023 · 12 comments · Fixed by #54092
Closed

Social Links Block: update Twitter Logo #53223

jeherve opened this issue Aug 1, 2023 · 12 comments · Fixed by #54092
Assignees
@jeherve
Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@jeherve
Copy link
Contributor

jeherve commented Aug 1, 2023

What problem does this address?

Twitter recently updated its branding from Twitter to "X". We may want to update references to Twitter in the Social Links block to match the new branding.

What is your proposed solution?

The "X" logo is currently an interim logo, but once the new logo is unveiled we may want to update all "Twitter" references to "X".
@jeherve jeherve mentioned this issue Aug 1, 2023
Closed
2 tasks
@t-hamano t-hamano added the [Block] Social Affects the Social Block - used to display Social Media accounts label Aug 1, 2023
@richtabor
Copy link
Member

richtabor commented Aug 1, 2023 •
edited
Loading

I think we'd want to add the X logo in addition to the Twitter logo; less forceful of a change on our end. And ensure there's a keyword so it can be found when searching for twitter.

@jordesign jordesign added the [Type] Enhancement A suggestion for improvement. label Aug 2, 2023
@t-hamano
Copy link
Contributor

t-hamano commented Aug 9, 2023

Update: It looks like the Brand toolkit for the new logo has been released.
https://about.twitter.com/en/who-we-are/brand-toolkit

@bgardner
Copy link

I'd like to see this icon included, and possibly added to the WP 6.3.1 release, given the amount of people who will likely want to use it. (Waiting 3 months for 6.4 might seem too far off.)

@t-hamano
Copy link
Contributor

This issue may be a bit daunting because it involves the entire WordPress project 😅

As far as I can think, at least for Gutenberg alone, we will need to change the brand name string (from "Twitter" to "x" or "𝕏" ), update the Social Link block and update the Embed block.

The following tickets have been submitted for the core: https://core.trac.wordpress.org/ticket/59012

@richtabor
Copy link
Member

we will need to change the brand name string (from "Twitter" to "x" or "𝕏" ), update the Social Link block and update the Embed block.

Like I mentioned earlier, I think this should be in addition to the existing Twitter social link variation.

@t-hamano
Copy link
Contributor

Like I mentioned earlier, I think this should be in addition to the existing Twitter social link variation.

I see. So it would be like this?

twitter

@richtabor
Copy link
Member

No, sorry. I meant leaving the Twitter variant as-is — but in addition, have the "X" variant. We could use a twitter keyword on the X variant though (not the title).

jeherve added a commit to jeherve/gutenberg that referenced this issue Aug 31, 2023
@jeherve
Social Links: add X
985f763 
Fixes WordPress#53223
jeherve added a commit to jeherve/gutenberg that referenced this issue Aug 31, 2023
@jeherve
Add Twitter keyword to variation
bbaede9 
This will allow people to find the new icon when searching for Twitter.

See WordPress#53223 (comment)
@jeherve jeherve mentioned this issue Aug 31, 2023
Merged
@github-actions github-actions bot added the [Status] In Progress Tracking issues with work in progress label Aug 31, 2023
priethor pushed a commit that referenced this issue Sep 25, 2023
@jeherve @t-hamano
@richtabor @ndiego
Social Links: add X (#54092)
5da68dc 
* Social Links: add X

Fixes #53223

* Add Twitter keyword to variation

This will allow people to find the new icon when searching for Twitter.

See #53223 (comment)

* Reorder links alphabetically

Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>

* No need for a capital letter

Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>

* Fix svg attributes

See #54092 (comment)

Co-authored-by: Rich Tabor <hi@richtabor.com>

* Remove "icon"

Co-authored-by: Nick Diego <nickmdiego@gmail.com>

* Update X icon path

See #54092 (comment)
See #54092 (comment)

---------

Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: Rich Tabor <hi@richtabor.com>
Co-authored-by: Nick Diego <nickmdiego@gmail.com>
@PeopleInside
Copy link

PeopleInside commented Sep 25, 2023 •
edited
Loading

When I can see this available on Gutemberg editor?
How can I have this fix?

mikachan pushed a commit that referenced this issue Sep 26, 2023
@jeherve @t-hamano
@richtabor @ndiego @mikachan
Social Links: add X (#54092)
0deec5f 
* Social Links: add X

Fixes #53223

* Add Twitter keyword to variation

This will allow people to find the new icon when searching for Twitter.

See #53223 (comment)

* Reorder links alphabetically

Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>

* No need for a capital letter

Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>

* Fix svg attributes

See #54092 (comment)

Co-authored-by: Rich Tabor <hi@richtabor.com>

* Remove "icon"

Co-authored-by: Nick Diego <nickmdiego@gmail.com>

* Update X icon path

See #54092 (comment)
See #54092 (comment)

---------

Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: Rich Tabor <hi@richtabor.com>
Co-authored-by: Nick Diego <nickmdiego@gmail.com>
mikachan pushed a commit that referenced this issue Sep 26, 2023
@jeherve @t-hamano
@richtabor @ndiego @mikachan
Social Links: add X (#54092)
af15294 
* Social Links: add X

Fixes #53223

* Add Twitter keyword to variation

This will allow people to find the new icon when searching for Twitter.

See #53223 (comment)

* Reorder links alphabetically

Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>

* No need for a capital letter

Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>

* Fix svg attributes

See #54092 (comment)

Co-authored-by: Rich Tabor <hi@richtabor.com>

* Remove "icon"

Co-authored-by: Nick Diego <nickmdiego@gmail.com>

* Update X icon path

See #54092 (comment)
See #54092 (comment)

---------

Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: Rich Tabor <hi@richtabor.com>
Co-authored-by: Nick Diego <nickmdiego@gmail.com>
Mamaduka added a commit that referenced this issue Sep 26, 2023
@mikachan @matiasbenedetto
@tyxla @jeherve @t-hamano @richtabor @ndiego @glendaviesnz @aaronrobertshaw @MaggieCabrera @scruffian @getdave @kevin940726 @spacedmonkey @Mamaduka
Latest cherry picks for WP 6.4 Beta 1 (#54833)
641b696 
* use the wporg cdn (#54795)

* core-data: Fix nested property access with undefined name (#54790)

* core-data: Fix nested property access with undefined name

* Add a unit test

* Social Links: add X (#54092)

* Social Links: add X

Fixes #53223

* Add Twitter keyword to variation

This will allow people to find the new icon when searching for Twitter.

See #53223 (comment)

* Reorder links alphabetically

Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>

* No need for a capital letter

Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>

* Fix svg attributes

See #54092 (comment)

Co-authored-by: Rich Tabor <hi@richtabor.com>

* Remove "icon"

Co-authored-by: Nick Diego <nickmdiego@gmail.com>

* Update X icon path

See #54092 (comment)
See #54092 (comment)

---------

Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: Rich Tabor <hi@richtabor.com>
Co-authored-by: Nick Diego <nickmdiego@gmail.com>

* remove font files created by tests after tests run (#54771)

* Check that new pattern is synced before replacing existing blocks with a synced pattern (#54804)

* Patterns: Improve sentence case consistency of labels and notices (#54807)

* Navigation block: fix padding on mobile overlay when global padding is 0 (#53725)

* force min value for padding to be 2rem

* fallback for when the css variables are not defined

* Allow the padding to be smaller than 2rem

* Add fix to avoid trigger hover state on links when overlay opens

---------

Co-authored-by: scruffian <ben@scruffian.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>

* Always show the total number of patterns even with only one page (#54813)

* Always show the total number of patterns even with only one page

* Add to explorer too

* Hide total number of 0

* Font Library: Avoid rendering Font Library UI outside Gutenberg plugin (#54830)

* Remove action to fix tests. (#54806)

* Conditionally remove deprecated 'print_emoji_styles' (#54828)

* Fix Performance tests

* Fix global styles revision

---------

Co-authored-by: Matias Benedetto <matias.benedetto@gmail.com>
Co-authored-by: Marin Atanasov <8436925+tyxla@users.noreply.github.com>
Co-authored-by: Jeremy Herve <jeremy@jeremy.hu>
Co-authored-by: Aki Hamano <54422211+t-hamano@users.noreply.github.com>
Co-authored-by: Rich Tabor <hi@richtabor.com>
Co-authored-by: Nick Diego <nickmdiego@gmail.com>
Co-authored-by: Glen Davies <glendaviesnz@users.noreply.github.com>
Co-authored-by: Aaron Robertshaw <60436221+aaronrobertshaw@users.noreply.github.com>
Co-authored-by: Maggie <maggie.cabrera@automattic.com>
Co-authored-by: scruffian <ben@scruffian.com>
Co-authored-by: Dave Smith <getdavemail@gmail.com>
Co-authored-by: Kai Hao <kevin830726@gmail.com>
Co-authored-by: Jonny Harris <spacedmonkey@users.noreply.github.com>
Co-authored-by: George Mamadashvili <georgemamadashvili@gmail.com>
@t-hamano
Copy link
Contributor

Hi @PeopleInside,

#54092 is part of Gutenberg 16.7. In other words, it is built into WordPress 6.4. You can see this icon in the recently released WordPress6.4 Beta1.

@He-Man321
Copy link

I have just upgraded to WP 6.4.1 but I still have the old Twitter icon. Is there something else I need to do?

@PeopleInside
Copy link

I have just upgraded to WP 6.4.1 but I still have the old Twitter icon. Is there something else I need to do?

I replied here: https://wordpress.org/support/topic/update-twitter-social-icon-x/#post-17210637

@He-Man321
Copy link

Just to add, as it confused me, you have to change the icon to the new one manually by editing the block (or adding a new one). The new X is now in the selector, but so is the old bird icon, so you have to manually change it. This is fine, but at first I assumed it would update automatically, which it does not.

Also, some themes have their own 'social' settings, and these may not have been updated yet (as with the Hueman theme in my case).

@evalarumbe evalarumbe mentioned this issue Dec 10, 2023
Closed
This was referenced Feb 15, 2024
Closed
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jeherve jeherve

Labels
[Block] Social Affects the Social Block - used to display Social Media accounts [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Social Links: add X jeherve/gutenberg
7 participants
@jeherve @bgardner @richtabor @jordesign @PeopleInside @He-Man321 @t-hamano