Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation in Site View: Make whole canvas clickable to enter focus mode. #51794

Closed
scruffian opened this issue Jun 22, 2023 · 4 comments · Fixed by #51973
Closed

Navigation in Site View: Make whole canvas clickable to enter focus mode. #51794

scruffian opened this issue Jun 22, 2023 · 4 comments · Fixed by #51973
Assignees
Labels
[Block] Navigation Affects the Navigation Block Needs Design Feedback Needs general design feedback.

Comments

@scruffian
Copy link
Contributor

What problem does this address?

When the site view shows only a navigation, it is not possible to click on the canvas to move to focus mode:
Screenshot 2023-06-22 at 12 37 24

What is your proposed solution?

Either we should make the whole canvas clickable, so that you can enter focus mode by clicking anywhere, or we should make the canvas much smaller, so it's only the same size as the navigation it contains.

cc @jasmussen for feedback

@scruffian scruffian added Needs Design Feedback Needs general design feedback. [Block] Navigation Affects the Navigation Block labels Jun 22, 2023
@jasmussen
Copy link
Contributor

The initial design assumes a frame that is centered vertically and horizontally, and is only as tall as the content itself, ie. your proposed solution 2:

Multiple menus

But solution 1, making the whole thing clickable, seems like a good interim solution, and presumably wouldn't preclude the other change from happening.

Remember though, that we need the Edit icon here as well:

Screenshot 2023-06-22 at 13 45 37

When clicking the preview on the right enters the Edit View, there should always be an edit button in the detail panel of the Site View.

@richtabor
Copy link
Member

The initial design assumes a frame that is centered vertically and horizontally, and is only as tall as the content itself, ie. your proposed solution 2:

Would be the case for all focus views, yea?

@jasmussen
Copy link
Contributor

Yes.

@getdave
Copy link
Contributor

getdave commented Jun 27, 2023

I have a PR to do the interim solution and we now have the edit icon as well.

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label Jul 24, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Needs Design Feedback Needs general design feedback.
Projects
Development

Successfully merging a pull request may close this issue.

5 participants