Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Flaky Test] should allow to return Global Styles root when example is clicked #50799

Closed
github-actions bot opened this issue May 19, 2023 · 0 comments · Fixed by #51365
Closed

[Flaky Test] should allow to return Global Styles root when example is clicked #50799

github-actions bot opened this issue May 19, 2023 · 0 comments · Fixed by #51365
Labels
[Type] Flaky Test Auto-generated flaky test report issue

Comments

@github-actions
Copy link

github-actions bot commented May 19, 2023

Flaky test detected. This is an auto-generated issue by GitHub Actions. Please do NOT edit this manually.

Test title

should allow to return Global Styles root when example is clicked

Test path

/test/e2e/specs/site-editor/style-book.spec.js

Errors

[2023-05-19T22:17:31.923Z] Test passed after 1 failed attempt on trunk.
[2023-05-20T03:45:26.669Z] Test passed after 1 failed attempt on add/elements-variations-custom-css.
[2023-05-20T16:06:46.362Z] Test passed after 1 failed attempt on codeowners/env.
[2023-05-20T17:30:43.577Z] Test passed after 1 failed attempt on trunk.
[2023-05-22T05:17:13.197Z] Test passed after 1 failed attempt on trunk.
[2023-05-22T05:38:38.655Z] Test passed after 1 failed attempt on add/text-orientation.
[2023-05-22T06:19:52.364Z] Test passed after 1 failed attempt on add/tag-selection-dropdown.
[2023-05-22T10:55:36.752Z] Test passed after 1 failed attempt on trunk.
[2023-05-22T11:16:10.765Z] Test passed after 1 failed attempt on add/url-assertion.
[2023-05-22T11:25:10.479Z] Test passed after 1 failed attempt on fix/template-parts-width.
[2023-05-22T14:18:08.439Z] Test passed after 1 failed attempt on trunk.
[2023-05-23T03:49:12.755Z] Test passed after 1 failed attempt on try/block-editing-mode.
[2023-05-23T07:44:53.779Z] Test passed after 1 failed attempt on remove/iframe-cached-documents.
[2023-05-23T09:10:40.510Z] Test passed after 1 failed attempt on rnmobile/fix/undo-redo-history.
[2023-05-23T13:14:09.826Z] Test passed after 1 failed attempt on trunk.
[2023-05-23T14:56:52.177Z] Test passed after 1 failed attempt on add/test-coverage-for-comments-template-block-context.
[2023-05-23T15:13:51.388Z] Test passed after 1 failed attempt on try/navigation-menu-focus-mode-experiment.
[2023-05-23T22:47:31.701Z] Test passed after 1 failed attempt on fix/wp-env-windows-start.
[2023-05-24T10:22:36.361Z] Test passed after 1 failed attempt on add/dynamic-templates.
[2023-05-24T10:56:44.869Z] Test passed after 1 failed attempt on add/back-to-top.
[2023-05-24T23:26:48.417Z] Test passed after 1 failed attempt on trunk.
[2023-05-25T05:30:17.726Z] Test passed after 1 failed attempt on update/file-spacing-support.
[2023-05-25T11:06:59.742Z] Test passed after 1 failed attempt on alternative-to-50235.
[2023-05-25T14:21:39.500Z] Test passed after 1 failed attempt on fix/image-block-lightbox-translation-escaping.
[2023-05-25T16:38:47.306Z] Test passed after 1 failed attempt on experiment/remove-interactivity-api-experimental-flag.
[2023-05-25T17:12:41.606Z] Test passed after 1 failed attempt on experiment/remove-interactivity-api-experimental-flag.
[2023-05-26T02:33:01.101Z] Test passed after 1 failed attempt on add/template-post-context-switching.
[2023-05-26T04:35:35.830Z] Test passed after 1 failed attempt on add/add-new-page.
[2023-05-26T04:47:25.326Z] Test passed after 1 failed attempt on trunk.
[2023-05-26T09:45:59.637Z] Test passed after 1 failed attempt on details/enable-by-default.
[2023-05-26T11:27:17.940Z] Test passed after 1 failed attempt on migrate-show-list-view-test.
[2023-05-26T13:51:13.628Z] Test passed after 1 failed attempt on migrate-should-contain-label.
[2023-05-28T15:54:35.456Z] Test passed after 1 failed attempt on fix/firefox-screen-reader-aria-describedby.
[2023-05-28T21:00:21.181Z] Test passed after 1 failed attempt on update/autocomplete-a11y-instructions.
[2023-05-29T02:09:25.649Z] Test passed after 1 failed attempt on add/dynamic-templates.
[2023-05-29T05:30:33.209Z] Test passed after 1 failed attempt on fix/firefox-screen-reader-aria-describedby.
[2023-05-29T06:25:35.263Z] Test passed after 1 failed attempt on update/separate-template-screens.
[2023-05-29T09:11:46.165Z] Test passed after 1 failed attempt on trunk.
[2023-05-29T10:19:37.019Z] Test passed after 1 failed attempt on fix/undo-redo.
[2023-05-29T13:06:49.343Z] Test passed after 1 failed attempt on trunk.
[2023-05-30T07:40:12.449Z] Test passed after 1 failed attempt on add/url-assertion.
[2023-05-30T09:17:58.496Z] Test passed after 1 failed attempt on trunk.
[2023-05-30T13:18:49.802Z] Test passed after 1 failed attempt on refactor/playwright-performance-tests.
[2023-05-30T15:57:54.766Z] Test passed after 1 failed attempt on update/separate-template-screens.
[2023-05-30T16:30:45.496Z] Test passed after 1 failed attempt on rnmobile/fix/fetch-translations-too-many-requests-error.
[2023-05-31T16:19:22.353Z] Test passed after 1 failed attempt on trunk.
[2023-06-01T08:14:31.211Z] Test passed after 1 failed attempt on trunk.
[2023-06-01T08:43:19.797Z] Test passed after 1 failed attempt on use/raw-attribute.
[2023-06-01T09:08:04.495Z] Test passed after 1 failed attempt on trunk.
[2023-06-01T09:33:05.895Z] Test passed after 1 failed attempt on use/raw-attribute.
[2023-06-01T10:12:19.541Z] Test passed after 1 failed attempt on trunk.
[2023-06-01T11:32:01.112Z] Test passed after 1 failed attempt on trunk.
[2023-06-01T16:26:30.520Z] Test passed after 1 failed attempt on fix/fonts-api/src-absolute-uris.
[2023-06-01T21:00:40.727Z] Test passed after 1 failed attempt on add/distraction-free-to-site-editor.
[2023-06-02T04:37:39.543Z] Test passed after 1 failed attempt on try/adding-non-synced-pattern-to-reusable-block-cpt.
[2023-06-02T04:43:28.733Z] Test passed after 1 failed attempt on trunk.
[2023-06-02T06:08:54.271Z] Test passed after 1 failed attempt on trunk.
[2023-06-02T11:15:34.424Z] Test passed after 1 failed attempt on trunk.
[2023-06-02T13:57:45.050Z] Test passed after 1 failed attempt on browse-mode-navigation-options.
[2023-06-02T15:31:10.890Z] Test passed after 1 failed attempt on update/clarify-compat-code-inline-styles.
[2023-06-02T16:00:19.800Z] Test passed after 1 failed attempt on try/font-library.
[2023-06-05T08:37:19.037Z] Test passed after 1 failed attempt on try/site-editor-library.
[2023-06-05T17:07:04.832Z] Test passed after 1 failed attempt on rename-syntax-to-double-hyphen-and-data-wp-interactive.
[2023-06-06T01:19:27.668Z] Test passed after 1 failed attempt on try/site-editor-library.
[2023-06-06T07:15:33.606Z] Test passed after 1 failed attempt on trunk.
[2023-06-06T08:46:03.183Z] Test passed after 1 failed attempt on trunk.
[2023-06-06T11:22:17.805Z] Test passed after 1 failed attempt on trunk.
[2023-06-06T13:32:38.119Z] Test passed after 1 failed attempt on update/behaviors-to-block-supports.
[2023-06-06T23:10:20.267Z] Test passed after 1 failed attempt on update/theme-json-schema-behaviors.
[2023-06-07T02:37:17.073Z] Test passed after 1 failed attempt on update/rename-page-content-lock.
[2023-06-07T08:45:08.086Z] Test passed after 1 failed attempt on try/font-library.
[2023-06-07T11:46:10.899Z] Test passed after 1 failed attempt on refactor/playwright-performance-tests.
[2023-06-08T02:40:41.284Z] Test passed after 1 failed attempt on rnmobile/release_1.97.0.
[2023-06-08T09:45:20.597Z] Test passed after 1 failed attempt on trunk.
[2023-06-08T12:31:45.594Z] Test passed after 1 failed attempt on fix/post-title-iframe-focus.
[2023-06-08T13:41:23.559Z] Test passed after 1 failed attempt on add/textarea-element.
[2023-06-08T14:35:30.850Z] Test passed after 1 failed attempt on add/categories-list-type.
[2023-06-08T18:32:32.335Z] Test passed after 1 failed attempt on rnmobile/upgrade/react-native-0.71.8.
[2023-06-08T19:33:39.931Z] Test passed after 1 failed attempt on feat/toggle-group-control-framer-motion-shared-layout.
[2023-06-08T20:40:47.680Z] Test passed after 1 failed attempt on refactor/remove-unnecesary-select-all.
[2023-06-08T20:40:58.827Z] Test passed after 1 failed attempt on tweak/linkcontrol-suggestions.
[2023-06-08T20:56:52.795Z] Test passed after 1 failed attempt on try/link-control-show-suggestions-on-dirty.
[2023-06-08T22:26:20.448Z] Test passed after 1 failed attempt on rnmobile/docs/fix-broken-links.
[2023-06-09T03:58:50.597Z] Test passed after 1 failed attempt on trunk.
[2023-06-09T06:11:36.542Z] Test passed after 1 failed attempt on fix/popover-handling-0-position.
Error: Timed out 5000ms waiting for expect(received).toBeVisible()
Call log:
  - expect.toBeVisible with timeout 5000ms
  - waiting for locator('role=region[name="Style Book"i]')
  - waiting for locator('role=region[name="Style Book"i]')

    at /home/runner/work/gutenberg/gutenberg/test/e2e/specs/site-editor/style-book.spec.js:27:5
@github-actions github-actions bot added the [Type] Flaky Test Auto-generated flaky test report issue label May 19, 2023
github-actions bot referenced this issue May 19, 2023
Co-authored-by: Ben Dwyer <ben@scruffian.com>
Co-authored-by: Jerry Jones <jones.jeremydavid@gmail.com>
github-actions bot referenced this issue May 22, 2023
* Remove Add Submenu option

* Remove Link UI entirely
github-actions bot referenced this issue May 23, 2023
…ollow single responsibility principle (#50266)

* Introduce prepend_to_selector() method to avoid additional if checks and follow single responsibility principle.

* Don't call append_to_selector() when selector is likely empty.

* Remove parameter completely instead of deprecating.

* Correct doc block.
github-actions bot referenced this issue May 24, 2023
…a dropZoneElement (#50726)

* List View: Allow dragging outside the immediate area by passing down a dropZoneRef from outside the list view

* Fix nesting logic so it will only nest if hovering over the bottom half of the item

* Update widget sidebar, too

* Update comments

* Update comments and types

* Use setTarget directly in the callback

* Fix issue where sometimes the expanded drop zone area was not being respected

* Add tests for useDropZone

* Update dependency array, we only need to look at the current key

* Swap out dropZoneRef for dropZoneElement

* Fix typo

* Add README file

* Update packages/compose/src/hooks/use-drop-zone/README.md

Co-authored-by: Daniel Richards <daniel.richards@automattic.com>

---------

Co-authored-by: Daniel Richards <daniel.richards@automattic.com>
github-actions bot referenced this issue May 26, 2023
…y in Firefox (#50540)

* Can't type space if a contenteditable element is inside button/summary in Firefox

commit

* Continue event processing only if within a specific element
github-actions bot referenced this issue Jun 2, 2023
* Add static column number option

* Address feedback and fix Group placeholder

* Revert non-responsive option

* Try using grid layout in Post Template

* Update Post Template to use auto-fill columns

* Add block spacing to post template

* Show gap control by default

* Add unstable columns grid property

* Rename layout column attribute.

* Add a media query to reproduce current responsiveness

* Move layout controls to Post Template block

* Reduce max columns to 6.

* Remove unstable prefix

* fix cols breaking out of container

* Try adding deprecation

* Fix broken loop

* Update fixtures

* Code improvements

* Add some comments to the CSS.

* Add back deleted line

* Remove legacy attributes in deprecation

* Fix deprecation logic

* Update fixtures

* Fallback gap for classic themes

* fix spacing

* match old default value

* Update PHP test strings.

* Fix tag discrepancy in fixtures
github-actions bot referenced this issue Jun 2, 2023
…page's template (#50857)

* Add ability to prevent editing blocks using useBlockEditingMode()

* Make useBlockEditingMode use context

* Remove rootBlockEditingMode setting

* Fix private createRegistrySelector selectors

* Consolidate templateLock=contentOnly logic into getBlockEditingMode

* Hide disabled blocks from List View

* Hide disabled blocks from breadcrumbs

* Add doc comments

* Add unit tests

* Use @typedef to document mode param

* Restore packages/components/package.json from trunk

* Restore packages/block-library/src/post-title/edit.js from trunk

* Move BlockListBlockContext out of block.js so that it exists on mobile platforms

* Site Editor: Add ability to focus on editing a page's content vs the page's template

* Show page information in DocumentActions

* Implement Content panel

* Prevent block overlay on disabled blocks

* Fix Navigation block being selectable

* Show 'Page' in breadcrumbs when focused on editing page

* Update post title, post featured image, and post content blocks to say 'Page' instead of 'Post'

* toolbar title styling

* Remove removePostFromContentBlockLabels for now

* Fix being able to select text within disabled blocks

* Hide BlockAppender when block is disabled

* Fix comments block in non-post templates

* Update template card selector in E2E tests

* Fix 'Add submenu' button in Navigation block

* Remove unhelpful comments

* Remove more unnecessary comments

* Use constant for block types array

* Use BEMish selectors

* Be explicit that we're switching away from the page lock

* Update removePageFromBlockContext() test

* Fix post context from appearing in Edit Template preview

We have to set postId and postType to null for the preview and omit them
in the editor. No point having helper methods, therefore.

* Clear block selection when switching from template focus to page focus

* Prevent insertion into a disabled block

* Don't allow removing and moving children of disabled blocks

* Work around @wordpress/data bug by not using createRegistrySelector() for now

* Fix typo

* Fix select() mock

* Fix block-editor selector tests

* Revert block-editor changes

* Improve useDisableNonContentBlocks performance

* Fix performance tests

---------

Co-authored-by: Saxon Fletcher <saxonafletcher@gmail.com>
Co-authored-by: ramon <ramonjd@gmail.com>
github-actions bot referenced this issue Jun 6, 2023
…51188)

* This commit updates the utilities to house logic to get the typography settings.
Why is this required? Because there's a little tap dance that's needed to check whether fluid typography is enabled via boolean or object, and also whether a maximum viewport size value can be extracted from layout settings.
Adds tests as well.

* - rename typographySettings here to typographyOptions to indicate that we're supposed to pass it the return value from getFluidTypographyOptionsFromSettings
- use TypographySettings as object return type
- test for null values in isFluidTypographyEnabled check
github-actions bot referenced this issue Jun 6, 2023
* Revise CSS to contain images within overlay properly

* Set horizontal images to occupy space of container

* Make square images fit by height rather than expand to full width

* Revise so lightbox loads original image; remove padding and hide caption

The lightbox will now load the original image when opened;
the src attribute is set dynamically so it will not be
unnecessarily loaded by the browser.

In addition, removed the padding and hid the caption.

* Fix PHP spacing for linter

* Fix test; image src is now only set after lightbox opens

* Improve styles for lightbox close button

* Fix PHP spacing for linter

* Darken the scrim

* Remove obsolte code
github-actions bot referenced this issue Jun 8, 2023
…owns (#51154)

* DropdownMenu: read variant from context

* Toolbar: do not set `variant` prop on popover (rely on context system instead)

* Use named export for better storybook doc generation

* Provide context value in more toolbar components

* Hook Dropdown into context system, update DropdownMenu and CircularOptionPicker

* Remove toolbar variant popover prop where the context system can be used instead

* Add comment where the context system currently doesn't work

* Use placement prop instead of legacy "position" prop

* Add some temporary TODO comments

* Set toolbar variant for Dropdown in the context system

* Remove explicit variant prop from block alignment matrix control

* Toolbar: Only set context in the top-level component

* Remove `toolbar` variant from instances using `Dropdown`

* Simplify Dropdown implementation

* Tidy up types

* Remove toolbar variant storybook example for Popover

* CHANGELOG

* Complete renaming internal type

* Remove duplicate hardcoded classnames(already added by context connexct)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Type] Flaky Test Auto-generated flaky test report issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

0 participants