Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Image: Add placeholder block state when adding from inserter #454

Closed
mtias opened this issue Apr 19, 2017 · 4 comments
Closed

Image: Add placeholder block state when adding from inserter #454

mtias opened this issue Apr 19, 2017 · 4 comments
Assignees
Labels
[Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time [Priority] High Used to indicate top priority items that need quick attention

Comments

@mtias
Copy link
Member

mtias commented Apr 19, 2017

image

The flow for inserting an image is:

  1. click the inserter
  2. click image block
  3. a placeholder is inserted, and the media library is opened
  4. pick an image from the media library
  5. the placeholder is replaced by the image

If you close the media library in step 4 without picking an image, you'll still see the placeholder.

@mtias mtias added [Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Apr 19, 2017
@jasmussen jasmussen added this to the Alpha milestone Apr 20, 2017
@jasmussen jasmussen changed the title Image: Add placeholder state when adding from inserter Image: Add placeholder block state when adding from inserter Apr 20, 2017
@jasmussen
Copy link
Contributor

Per a discussion in #317, perhaps we should make an exception for images and galleries, and skip the placeholder? That is, you invoke the inserter, click image, and are then immediately taken to the "insert image" tab in the media library. Same with gallery, except you are taken to the gallery tab.

In both cases, dragging image(s) into the editor should upload & insert.

@jasmussen
Copy link
Contributor

Here's a new mockup for creating galleries via the media library, as opposed to via placeholders. If we like that, we should probably do the same for images: #317 (comment)

@mtias
Copy link
Member Author

mtias commented Apr 28, 2017

Update: we still need the image placeholder state because if dismiss the media library after it pops up, an empty block remains. Also the empty state will show through behind media library.

@mtias mtias added the [Priority] High Used to indicate top priority items that need quick attention label Apr 28, 2017
@aduth aduth self-assigned this Apr 28, 2017
@jasmussen
Copy link
Contributor

Added flow description based on recent discussions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks Good First Issue An issue that's suitable for someone looking to contribute for the first time [Priority] High Used to indicate top priority items that need quick attention
Projects
None yet
Development

No branches or pull requests

3 participants