Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Figure out media integration. #418

Closed
mtias opened this issue Apr 13, 2017 · 3 comments · Fixed by #802
Closed

Figure out media integration. #418

mtias opened this issue Apr 13, 2017 · 3 comments · Fixed by #802
Assignees
@youknowriad
Labels
Framework Issues related to broader framework topics, especially as it relates to javascript General Interface Parts of the UI which don't fall neatly under other labels. [Type] Task Issues or PRs that have been broken down into an individual action to take
Milestone
May Week 3 (Alpha)

Comments

@mtias
Copy link
Member

mtias commented Apr 13, 2017

In the not distant future we need to start integrating this. Related #310

@westonruter you may have thoughts on this as part of the media widgets work.
@mtias mtias added Framework Issues related to broader framework topics, especially as it relates to javascript [Type] Task Issues or PRs that have been broken down into an individual action to take labels Apr 13, 2017
@westonruter
Copy link
Member

The different media widget types should provide good examples for how to invoke the media library, passing in a state, and getting a mutated state back out for use in blocks.

One thing we just came up against in the realm of embeds is the fact that currently the parse-embed admin-ajax request requires a post_ID for context. This request is used to preview an embed in the media modal frame and also (currently) when the media is shown in the TinyMCE editor. The post_ID is required I believe because WordPress currently caches external oEmbed responses in postmeta.

There has been some discussion about enhancing the embed REST API endpoints in core to support the proxy use case, as opposed to just getting an embed for a post/page. See https://wordpress.slack.com/archives/C02RQC26G/p1492038272597233

@jasmussen
Copy link
Contributor

Some relevant discussion in #454 (comment)

@mtias mtias added the General Interface Parts of the UI which don't fall neatly under other labels. label May 3, 2017
@youknowriad youknowriad mentioned this issue May 12, 2017
Closed
@westonruter
Copy link
Member

Note that media manager is no longer dependent on having a post for context to fetch oEmbed data. It now makes use of the new oEmbed proxy endpoint in the core REST API.

@jasmussen jasmussen added this to the May Week 3 (Alpha) milestone May 16, 2017
@youknowriad youknowriad self-assigned this May 16, 2017
@youknowriad youknowriad mentioned this issue May 16, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@youknowriad youknowriad

Labels
Framework Issues related to broader framework topics, especially as it relates to javascript General Interface Parts of the UI which don't fall neatly under other labels. [Type] Task Issues or PRs that have been broken down into an individual action to take
Projects
None yet
Milestone
May Week 3 (Alpha)
Development

Successfully merging a pull request may close this issue.

Image Block: Integrate with the media upload modal WordPress/gutenberg
4 participants
@westonruter @youknowriad @mtias @jasmussen