Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make disabled state of toolbar buttons easier work out or hide them until in use #3928

Closed
karmatosed opened this issue Dec 11, 2017 · 6 comments · Fixed by #4033
Closed

Make disabled state of toolbar buttons easier work out or hide them until in use #3928

karmatosed opened this issue Dec 11, 2017 · 6 comments · Fixed by #4033
Labels
Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@karmatosed
Copy link
Member

karmatosed commented Dec 11, 2017

I appreciate there is a fine line between fading and people being unable to see. The current disabled treatment of the toolbar though, means that it's incredibly hard to work out if it's disabled. I have a few suggestions:

artboard

  1. Shows the current state.
  2. Make the fading more increased (as seen in the second version in mockup). The downside of this is visibility, but right now they aren't accessible and as they are disabled we need to work out do they need to be even seen.
  3. Make the '+' a blue. This brings in color but it does make it visible. I am not sold this is best but it certainly means I can work out what is disabled and what isn't.

Playing on a little from my point in 2, if they don't need to be seen why are we showing them? Would maybe a better approach be to not even have them show until usable?

@karmatosed karmatosed added the Needs Design Feedback Needs general design feedback. label Dec 11, 2017
@karmatosed karmatosed changed the title Make disabled state of toolbar buttons easier to know Make disabled state of toolbar buttons easier work out or hide them until in use Dec 11, 2017
@afercia
Copy link
Contributor

afercia commented Dec 11, 2017

Reminder: from an a11y perspective disabled controls don't need a sufficient color contrast. Quoting:

Text or images of text that are part of an inactive user interface component, that are pure decoration, that are not visible to anyone, or that are part of a picture that contains significant other visual content, have no contrast requirement.

Hiding them completely doesn't sound right to me though 🙂

@karmatosed
Copy link
Member Author

karmatosed commented Dec 12, 2017

Hiding them completely doesn't sound right to me though

Why not? They aren't being used and they don't serve a purpose visually. If they are active they would appear.

Reminder: from an a11y perspective disabled controls don't need a sufficient color contrast.

Interesting you say because I found this issue because of an accessibility problem. My eyesight actually is not awesome at low contrast and I couldn't tell the difference between an active/disabled :)

@afercia
Copy link
Contributor

afercia commented Dec 12, 2017

I'm not sure I fully understand 🙂 Are you saying, for example, when editing an existing post, since "Undo" and "Redo" are disabled they should be hidden and users should see just the inserter and the info buttons? See below:

screen shot 2017-12-12 at 15 15 28

@karmatosed
Copy link
Member Author

I'm saying that's one possible way. Right now it's easy to click those and get nothing back. That's not a great user experience as someone could assume it's broken. The contrast is too low to notice the disabled state.

@jasmussen
Copy link
Contributor

It seems to me like the obvious fix here is to just dim the disabled buttons further i.e. option 2, and it also sounds like there aren't any accessibility issues with this?

@karmatosed karmatosed added Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement. and removed Needs Design Feedback Needs general design feedback. labels Dec 14, 2017
@karmatosed
Copy link
Member Author

Awesome, lets for now do 2 in that screenshot then. Make the fading stronger.

@karmatosed karmatosed added this to the 2.0.0 milestone Dec 14, 2017
jasmussen pushed a commit that referenced this issue Dec 15, 2017
This changes the opacity of a disabled button to be .3 opacity from .6 previously. This fixes #3928
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants