-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make disabled state of toolbar buttons easier work out or hide them until in use #3928
Comments
Reminder: from an a11y perspective disabled controls don't need a sufficient color contrast. Quoting:
Hiding them completely doesn't sound right to me though 🙂 |
Why not? They aren't being used and they don't serve a purpose visually. If they are active they would appear.
Interesting you say because I found this issue because of an accessibility problem. My eyesight actually is not awesome at low contrast and I couldn't tell the difference between an active/disabled :) |
I'm saying that's one possible way. Right now it's easy to click those and get nothing back. That's not a great user experience as someone could assume it's broken. The contrast is too low to notice the disabled state. |
It seems to me like the obvious fix here is to just dim the disabled buttons further i.e. option 2, and it also sounds like there aren't any accessibility issues with this? |
Awesome, lets for now do 2 in that screenshot then. Make the fading stronger. |
This changes the opacity of a disabled button to be .3 opacity from .6 previously. This fixes #3928
I appreciate there is a fine line between fading and people being unable to see. The current disabled treatment of the toolbar though, means that it's incredibly hard to work out if it's disabled. I have a few suggestions:
Playing on a little from my point in 2, if they don't need to be seen why are we showing them? Would maybe a better approach be to not even have them show until usable?
The text was updated successfully, but these errors were encountered: