Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Widgets editor: Block appender does not appear as full width #38390

Closed
noisysocks opened this issue Feb 1, 2022 · 4 comments · Fixed by #38846
Closed

Widgets editor: Block appender does not appear as full width #38390

noisysocks opened this issue Feb 1, 2022 · 4 comments · Fixed by #38846
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Widgets Screen The block-based screen that replaced widgets.php. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended

Comments

@noisysocks
Copy link
Member

noisysocks commented Feb 1, 2022

Description

The block appender in the Widgets screen appears as a small button to the right of the widget area. It should expand to fill the widget area.

You could potentially use git bisect to find what commit broke this.

Step-by-step reproduction instructions

  1. Activate a classic theme.
  2. Go to Appearance → Widgets.
  3. Look at the block appender at the bottom of any widget area.

Screenshots, screen recording, code snippet

Screen Shot 2022-02-01 at 12 15 50

You can see what the appender button should look like when there are no blocks in the widget area:

Screen Shot 2022-02-04 at 10 43 00

Environment info

No response

Please confirm that you have searched existing issues in the repo.

Yes

Please confirm that you have tested with all plugins deactivated except Gutenberg.

Yes

@noisysocks noisysocks added [Feature] Widgets Screen The block-based screen that replaced widgets.php. [Type] Bug An existing feature does not function as intended CSS Styling Related to editor and front end styles, CSS-specific issues. Good First Issue An issue that's suitable for someone looking to contribute for the first time labels Feb 1, 2022
@itsmingjie
Copy link

Hi! I'm one of the program coordinators of a nonprofit program called CodeDay Init, and we partner with colleges to help CS students make their first open-source contribution.

We'll claim this issue for now and a group of students will be on it soon with mentorship! If this issue is no longer relevant, please let me know.

@noisysocks
Copy link
Member Author

Thanks @itsmingjie! The issue is still relevant. Let me know if you need help or extra info.

@upluke
Copy link

upluke commented Feb 12, 2022

@noisysocks Hi, my group is working on this issue. We think we're located the styling on this issue. It seems it's part of wordPress issue instead gutenberg issue. Is it possible this might be the case?

@noisysocks
Copy link
Member Author

Hello! The code that implements this is in the edit-widgets package, which is in the Gutenberg repo. WordPress imports this package which is how it ends up there.

https://github.com/WordPress/gutenberg/blob/trunk/packages/edit-widgets/

mjstoney added a commit to codeday-init-2022-spring/gutenberg that referenced this issue Feb 16, 2022
@noisysocks noisysocks linked a pull request Feb 16, 2022 that will close this issue
8 tasks
noisysocks pushed a commit that referenced this issue Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CSS Styling Related to editor and front end styles, CSS-specific issues. [Feature] Widgets Screen The block-based screen that replaced widgets.php. Good First Issue An issue that's suitable for someone looking to contribute for the first time [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants