Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Query Title: Search and 404 pages. #33476

Closed
scruffian opened this issue Jul 15, 2021 · 4 comments
Closed

Query Title: Search and 404 pages. #33476

scruffian opened this issue Jul 15, 2021 · 4 comments
Assignees
@carolinan
Labels
[Block] Query Title Affects the Query Title Block

Comments

@scruffian
Copy link
Contributor

scruffian commented Jul 15, 2021 •
edited
Loading

What problem does this address?

The Query Title block is empty on the Search page

What is your proposed solution?

The Query Title blocks should display "Search results" on a search page and "Nothing found" on a 404 page.

Some prior work on this here: #27989
@mikachan mikachan mentioned this issue Jul 16, 2021
Closed
7 tasks
@coreymckrill
Copy link
Contributor

I would also add the Posts page. If the site is configured with static pages for the Homepage and Posts page, it should output the page title of the Posts page. If the site is configured to show "Your latest posts", perhaps it could default to just "Posts" but then also be customizable via a block attribute?

@coreymckrill coreymckrill mentioned this issue Oct 14, 2021
Merged
@coreymckrill
Copy link
Contributor

Also, I think ideally the type attribute wouldn't be necessary in this block, because it would be able to automatically identify which type of query it's in and output the appropriate title. That way the block could be used in a block template part that gets reused across multiple types of views.

@iandunn iandunn mentioned this issue Oct 26, 2021
Closed
2 tasks
This was referenced Nov 4, 2021
Closed
Open
Open
Open
Open
dcalhoun added a commit to dcalhoun/life-stewardship that referenced this issue Apr 19, 2022
@dcalhoun
Add static Blog heading
2a397ff 
This should be displayed by `wp:archive-title`, but it currently does
not support that. This static heading means there is now duplicative
level one headings on archive pages, which is not ideal.

WordPress/gutenberg#33476
dcalhoun added a commit to dcalhoun/life-stewardship that referenced this issue Apr 19, 2022
@dcalhoun
Add static Blog heading
c0a945d 
This should be displayed by `wp:archive-title`, but it currently does
not support that. This static heading means there is now duplicative
level one headings on archive pages, which is not ideal.

WordPress/gutenberg#33476
dcalhoun added a commit to dcalhoun/life-stewardship that referenced this issue May 8, 2022
@dcalhoun
Add WordPress theme (#31)
15af7c0 
* Remove Next.js site

* Add foundational files

* Add gitignore

* Add @wordpress/env

* Add Prettier

* Fix theme slugs

* Add Prettier config

* Remove parent theme

* Add README

* Add files from Blockbase theme

* Fix index file after removing Blockbase parent them

* [wip] Add Tailwind CDN

* Remove unused navigation menu registration

* Disable unused embeds script

Improve performance.

* Disable unused emojis script

Improve performance.

* Simplify index.php

* Remove unstable navigation attributes

* Remove reference to TinyMCE that threw error

* Improve header alignment

* Rename template directories

* Update footer punctuation

* Remove unidentified theme support hook

Unsure of the nature of this hook.

* Clean up and sync functions.php file with Blockbase theme

* Replace outdated branch reference

The primary branch is named "main."

* Reinstate theme stylesheet

* Fix white space within footer template part

Prettier mangles the white space found in the span element.

* Explore baseline typography in theme.json configuration

* Decrease small font size

Create consistent scale steps.

* Remove unused template parts

* Improve template implementation

* Fix font size CSS property

* Update font family configuration

* Update theme color configuration

* Add header styles

* Remove feature image from page and single templates

* Update navigation styles

* Update post title level and styles

* Round featured image

* Revert "Remove feature image from page and single templates"

This reverts commit 8917b2301a80e4ede1ae1e1d307091901176ffda.

* Revert "Remove unused template parts"

This reverts commit 26508dc09b85214f8f39e5eba3f815573de89e2b.

* Explore custom post type for styled page

Stylized page includes locked featured image block. This improves the
WYSIWYG experience for pages by displaying the featured image in the
editor.

* Modify existing Page post type rather than creating new post type

Simplify the approach to including the Post Featured Image block for all
Pages.

* Remove featured image from page template

This is now a part of the page content blocks instead.

* Enable custom block padding

Allow required spacing for home page columns.

* Round post featured images

* Inline Post Featured Image for Pages and Posts

* Rename Blockbase references

* Add bottom spacer to header

* Add Callout pattern

* Set rounded images in theme.json

* Customize blockGap

* Relocate navigation styles to theme.json

* Reduce default content width

* Fix header vertical rhythm

* Add Affiliation pattern

* Format theme.json

* Fix paragraph line height

* Prevent post content from touching window side

* Fix post title alignment

* Remove custom navigation item gap

* Rename front page template for clarity

* Update Footer design

* Fix contact form button styles

The Jetpack styles override theme button style configuration.
Automattic/jetpack#19527 (comment)

* Improve footer spacing

* Fix template syntax error

* Improve Affiliation pattern design

* Add horizontal Header and Footer padding

* Remove unused post-meta-icons template part

* Update Post Meta design

* Format stylesheet

* Replace pixels with rem

* Set button to primary action color

* Fix Footer part syntax error

* Fix reference to Post Meta parts

* Rename templates for clarity

* Disable mobile navigation overlay

* Add static Blog heading

This should be displayed by `wp:archive-title`, but it currently does
not support that. This static heading means there is now duplicative
level one headings on archive pages, which is not ideal.

WordPress/gutenberg#33476

* Fix overflowing horizontal separator on small screens

* Remove unnecessary patch script

The customizer bug is unlikely to impact our use case.

* Fix header background color

* Improve Callout pattern responsive styles

* Fix Affiliation responsive styles

* Fix Index post title spacing

* Add horizontal padding to avoid window sides

* Update pattern padding

* Format patterns

* Format code

* Fix Callout secondary heading

After formatting the code, the empty `em` caused the block editor to
think the heading was pre-populated.

* Mirror query title line height to post title

* Enable border-box globally

* Style quote and pull quote blocks

* Fix Jetpack button padding

* Rename custom variables

* Fix credit spacing

* Balance Affiliation height

* Remove ls- prefix from CSS selectors

* Reorganize stylesheets and images

* Fix list alignment

* Style figure caption

* Fix post comment alignment

* Adjust block quote alignment

* Fix block syntax error

* Avoid block name in HTML comment

* Enable mobile overlay navigation

* Set edge spacing variable

* Adjust spacing and typography

* Simplify stylesheet loading

Reduce stylesheet organization to a single file given the block editor's
long-term goal of avoiding stylesheet files in general.

* Fix credit spacing

Prettier formatting causes white space in the HTML.

* Remove custom list styles

The default list styles suffice.

* Add font smoothing

* Use static block gap value

* Fix image paths in stylesheet

* Style form input elements

* Style button hover state

* Remove unnecessary template part scope

* Rename theme slug to match community pattern

* Scope form input styles to Jetpack

The global styles caused oddities for the Jetpack Contact block in the
block editor.

* Add theme screenshot

* Update license to GPL-2.0-or-later

* Remove WordPress name from package name

* Fix styling issues on WordPress.com

* Increase footer spacing

* Reinstate theme attribute for template part

Unsure as to why this returned from the block editor, but it likely
makes sense to retain it.

* Add full-page screenshot

WordPress.com's Calypso displays a larger preview than default WordPress
installations.

* Improve screenshot aspect ratio
@carolinan carolinan self-assigned this Jul 22, 2022
@carolinan carolinan mentioned this issue Jul 25, 2022
Merged
@carolinan
Copy link
Contributor

Do we still want a title specifically for the 404 page? I am not sure it would be helpful to have a block that could just as well be a heading block.

@scruffian
Copy link
Contributor Author

The only advantage I see is translation, but since we can handle that with patterns then perhaps we can close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@carolinan carolinan

Labels
[Block] Query Title Affects the Query Title Block
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@scruffian @coreymckrill @carolinan