Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename Post Tags block to PostNonHierarchicalTerms block and make a Post Tags variation instead. #31422

Closed
youknowriad opened this issue May 3, 2021 · 2 comments · Fixed by #31458
Assignees
Labels
[Feature] Blocks Overall functionality of blocks [Status] In Progress Tracking issues with work in progress

Comments

@youknowriad
Copy link
Contributor

Right now we have two post taxonomies blocks:

  • postHierarchicalTerms
  • postTags

The former is generic and support post categories variations, the latter is specific to tags. We should consider renaming the latter and make a variation for tags to match the behavior of the hierarchical terms block.

I think this is important to do before shipping these blocks to Core.

cc @carolinan @mtias

@youknowriad youknowriad added the [Feature] Blocks Overall functionality of blocks label May 3, 2021
@mtias
Copy link
Member

mtias commented May 3, 2021

It sounds good to me though I'm a bit confused why it's called hierarchichalTerms when tags are not hierarchichal. Should the base block be just postTerms?

@youknowriad
Copy link
Contributor Author

I was actually suggesting tags to be a variation of postNonHierarchicalTerms or something like that (just like categories is a variation of postHierarchicalTerms right now).

Now, looking at the output of the two blocks and comparing them (categories and tags), it seems that the output is very similar regardless of whether the taxonomy is hierarchical or not. So yeah in that case a single postTerms block with two variations makes more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Status] In Progress Tracking issues with work in progress
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants