Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling Full Site Editor blocks in classic themes #28744

Closed
priethor opened this issue Feb 4, 2021 · 9 comments · Fixed by #31423 or #31499
Closed

Enabling Full Site Editor blocks in classic themes #28744

priethor opened this issue Feb 4, 2021 · 9 comments · Fixed by #31423 or #31499
Assignees
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Discussion For issues that are high-level and not yet ready to implement. [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.

Comments

@priethor
Copy link
Contributor

priethor commented Feb 4, 2021

With the upcoming inclusion of Full Site Editing in WP 5.8, many of the site-editing-oriented blocks currently enabled only with FSE should also be available to use in classic themes. The goal of this issue is to list all these blocks and determine whether each of them should also be enabled in non-FSE contexts.

Block Should be enabled without FSE? Related Issue
siteLogo #30406
siteTagline #30921
siteTitle #30918
templatePart
query #26316, #30910
queryLoop #26316
queryPagination
postTitle
postContent
postAuthor
postComment
postCommentAuthor
postCommentContent
postCommentDate
postComments
postCommentsCount
postCommentsForm
postDate
postExcerpt
postFeaturedImage
postHierarchicalTerms
postTags
archiveTitle
termDescription
loginOut

These blocks will be categorized in the block inserter as defined in #26639

@priethor priethor added [Feature] Blocks Overall functionality of blocks [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Feature] Full Site Editing [Type] Discussion For issues that are high-level and not yet ready to implement. labels Feb 4, 2021
@priethor priethor changed the title Enabling Full Site Editing blocks in non-FSE editors Enabling Site Editing blocks in non-FSE editors Feb 4, 2021
@skorasaurus
Copy link
Member

There's an issue about this for the Query Block at #26316

@priethor priethor changed the title Enabling Site Editing blocks in non-FSE editors Enabling Full Site Editor blocks in classic themes Feb 4, 2021
@carolinan
Copy link
Contributor

I would find the post excerpt useful.
A use case would be to have a custom excerpt showing in an archive, and then be used as lead text for the individual post.

@priethor
Copy link
Contributor Author

All in all, it seems we kind of need most blocks except the "template part" block, which only makes sense in a Site Editing context.

@priethor
Copy link
Contributor Author

As far as the Query block is concerned, we need to include all individual block variations built on top of the main Query block (e.g., "Posts block", "Pages block", which are the ones that end-users will be facing in the inserter, as well as Query block patterns (#28891)

@mtias
Copy link
Member

mtias commented Apr 16, 2021

Updated the issue to exclude the "comments" related ones, since those make more sense for single page templates and need a bit more work.

@priethor
Copy link
Contributor Author

priethor commented Apr 19, 2021

Added to the list the 3 new theme blocks that landed in 10.3 (Login/Out, Term Description, and Archive Title) for tracking purposes, although they don't seem to make a lot of sense with the Landing page scope of 5. Moreover, without #30679 the archive blocks can be used in any template even if they are not meant to.

@carolinan carolinan added the [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues. label Apr 20, 2021
@priethor
Copy link
Contributor Author

Added the Login/Out as it can indeed be useful if added to a Widget Area thanks to the Widgets Editor project.

@youknowriad
Copy link
Contributor

Reopening because there are some blocks left that we'd want to reconsider.

@priethor priethor removed the [Status] In Progress Tracking issues with work in progress label May 6, 2021
@grappler
Copy link
Member

The postAuthor block was not included in WP 5.8 #31983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Blocks Overall functionality of blocks [Feature] Themes Questions or issues with incorporating or styling blocks in a theme. [Type] Discussion For issues that are high-level and not yet ready to implement. [Type] Tracking Issue Tactical breakdown of efforts across the codebase and/or tied to Overview issues.
Projects
None yet
6 participants