-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
File Block: Change the button to a Button Block #27760
Labels
[Block] File
Affects the File Block
[Feature] Themes
Questions or issues with incorporating or styling blocks in a theme.
Comments
scruffian
added
[Block] File
Affects the File Block
[Feature] Themes
Questions or issues with incorporating or styling blocks in a theme.
[Feature] Full Site Editing
labels
Dec 16, 2020
Had a quick look at this, but because it will require converting the block to use innerBlocks, it will currently suffer from the same issue as noted here in the Quote block conversion to innerBlocks PR, so probably best to leave until @dmsnell works through that. |
I think the best way forward here is to use an "element button": #40260 |
This was closed by #40260 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
[Block] File
Affects the File Block
[Feature] Themes
Questions or issues with incorporating or styling blocks in a theme.
Is your feature request related to a problem? Please describe.
The File Block has its own implementation of a button.
Describe the solution you'd like
The File Block should use the button Block so that the button can have the same controls as other buttons.
The text was updated successfully, but these errors were encountered: