Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Navigation Block: Text settings not working #23258

Closed
alaczek opened this issue Jun 18, 2020 · 6 comments · Fixed by #23360
Closed

Navigation Block: Text settings not working #23258

alaczek opened this issue Jun 18, 2020 · 6 comments · Fixed by #23360
Labels
[Block] Navigation Affects the Navigation Block Needs Dev Ready for, and needs developer efforts [Type] Bug An existing feature does not function as intended

Comments

@alaczek
Copy link

alaczek commented Jun 18, 2020

Site Navigation block offers some Text settings in the sidebar, but they seem to have no effect on either editor or the front end.

To reproduce
Steps to reproduce the behavior:

  1. Add Navigation block to a post or a page.
  2. With the block selected scroll down in the sidebar to Text settings.
  3. Try different preset sizes. Notice the font-size is not being applied to the block.
  4. Preview the post/page. Note that the font-size is not being applied on the frontend of the site either.

This seems to be because of the following styles applied to the span element via .wp-block-navigation-link__label class, which override the theme styling:

.wp-block-navigation-link__label {
    font-size: 17px;
    font-family: -apple-system,BlinkMacSystemFont,Segoe UI,Roboto,Oxygen-Sans,Ubuntu,Cantarell,Helvetica Neue,sans-serif;
    word-break: normal;
    overflow-wrap: break-word;
}

Screenshots
rrluEbZ6Oy

Editor version (please complete the following information):

  • WordPress version: 5.4.2
  • Gutenberg plugin: 8.3.0
  • Theme: TwentyTwenty v1.4
@talldan talldan added [Block] Navigation Affects the Navigation Block Needs Testing Needs further testing to be confirmed. labels Jun 18, 2020
@talldan
Copy link
Contributor

talldan commented Jun 18, 2020

@alaczek I couldn't find those text settings. It might be that they're provided by a plugin you have active?

@alaczek
Copy link
Author

alaczek commented Jun 18, 2020

Hmm, that is strange. I deactivated all plugins aside from Gutenberg, and still, those settings for Navigation block were available. Maybe we need a third pair of eyes :)

@annezazu
Copy link
Contributor

@talldan @alaczek I tested this and could see the text settings. You need to select the entire block in order to see these settings. Here's a video replicating this: https://cloudup.com/c2uXL_JKGfG

Of note, it's pretty confusing how different the block settings screen is when selecting the entire block vs when you are working within the block itself.

  • WordPress 5.4.2
  • Gutenberg 8.3.0
  • TwentyTwenty theme
  • No other plugins active

Removing the needs-testing tag!

@annezazu annezazu added [Type] Bug An existing feature does not function as intended Needs Dev Ready for, and needs developer efforts and removed Needs Testing Needs further testing to be confirmed. labels Jun 18, 2020
@kirilzh
Copy link
Contributor

kirilzh commented Jun 22, 2020

Updating Default style will save your preference for future navigation blocks e.g. if you select dark and add one more navigation block it will be dark. I'm not sure this is the best place to be making this decision. I was confused as to what needs to happen and it took me some time to figure it out.

@kirilzh kirilzh added the Needs Design Feedback Needs general design feedback. label Jun 22, 2020
@kirilzh kirilzh removed the Needs Design Feedback Needs general design feedback. label Jun 22, 2020
@talldan
Copy link
Contributor

talldan commented Jun 24, 2020

Thanks, I see it happening now 👍

kirilzh added a commit to kirilzh/gutenberg that referenced this issue Jun 30, 2020
@unprintedch
Copy link

Why is there a font family in the first place?
It should get this from the thème right?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Navigation Affects the Navigation Block Needs Dev Ready for, and needs developer efforts [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants