Cmd + K to add link to a Button block focuses the browser address bar in Firefox

[talldan]

Describe the bug
Using a shortcut to add a link to the button block doesn't work in Firefox. Furthermore, multiple link popovers can be opened for multiple buttons (though this problem will likely go away when the first issue is fixed).

To reproduce
Steps to reproduce the behavior:

1. Create a post in Firefox (Tested on Mac OS X)
2. Add a Buttons block
3. Press Cmd+K to add a link to the block
4. Observe that the browser address or search bar is focused prompting the user to search
5. Add another button to the buttons block
6. Press Cmd+K again.
7. Observe multiple overlapping LinkControl popovers

Expected behavior
The link popover is focused when using the shortcut (preventDefault).

Clicking outside an opened popover closes it.

[afercia]

For me, macOS Firefox in English, Cmd+K focuses the Firefox Search instead (the one on the right of the address bar). I think the standard Firefox shortcut to focus the address bar is Cmd+L (L as "Location"), at least for English.

[talldan]

@afercia Good point. I think it's possible to have Firefox setup to either have separate search and address bars or a single unified bar. I have the latter configured in my Firefox.

[afercia]

Ah good point. Maybe new installations get the unified bar? I guess old installations that get updated retain old settings.

[afercia]

For reference: here's the related Firefox preference:

And yes, when "Use the address bar for search and navigation" is on, Cmd+K moves focus to the unified address/search bar.

Regardless, wouldn't this be solved with a simple preventDefault()?

[kirilzh]

I traced the bug down to

gutenberg/packages/block-library/src/button/edit.js

Line 113 in f5b0c42

[ rawShortcut.primary( 'k' ) ]: openLinkControl,

Currently there doesn't seem to be a way to preventDefault in <KeyboardShortcuts />

[talldan]

I think that would be handled in the openLinkControl event handler, @kirilzh.