Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block API: Explore how block variations could be embedded in other places #20584

Closed
gziolo opened this issue Mar 2, 2020 · 4 comments
Closed
Labels
[Feature] Block API API that allows to express the block paradigm. [Feature] Inspector Controls The interface showing block settings and the controls available for each block [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Enhancement A suggestion for improvement.

Comments

@gziolo
Copy link
Member

gziolo commented Mar 2, 2020

Description

Follow-up for #16283.

Some ideas were previously shared by @kjellr in #16283 (comment):

In many cases, it'll make sense to include these options in the setup state. Beyond that, they'll likely also need to live in either the Block Switcher menu, or in the Sidebar:

Layout Options in the Sidebar:
03

Layout Options in the Block Switcher:
Frame 2 1

@gziolo gziolo added [Type] Enhancement A suggestion for improvement. [Feature] Block API API that allows to express the block paradigm. Needs Dev Ready for, and needs developer efforts [Feature] Inspector Controls The interface showing block settings and the controls available for each block labels Mar 2, 2020
@gziolo gziolo changed the title Block API: Explore how block variations could be embedded in the inspector controls Block API: Explore how block variations could be embedded in other places Mar 2, 2020
@ocean90
Copy link
Member

ocean90 commented May 10, 2020

It would be nice to have at least one of the options since it doesn't seem to be possible to use transforms to switch to another variation due to the same block name.

@paaljoachim
Copy link
Contributor

paaljoachim commented Jun 11, 2020

It seems this issue is very much associated:
#20583


Suggestion that we add a new Layout sidebar panel.

Layout is the top level in a Block. As it has to do with how the block elements are laid out.
Styles is the styling of the elements inside the Block.
Today styles and layouts are somewhat mixed together in one panel.

A figma example with the Columns Block: (We can also switch out the word variation with layout.)
Variation panel

2 Sidebar - Open Layout panel

Mini prototype.
https://www.figma.com/proto/HcOy92XlgMNtUjH5KF2Os0/New-Sidebar-Layout-Panel?node-id=2%3A0&scaling=min-zoom

Examples where a Layout panel would be good to have:
Columns.
Media & Text.
Buttons Block, Navigation Block and Social Icons Block - horizontal/vertical layout.
and probably other blocks as well.

@ntsekouras
Copy link
Contributor

This shouldn't be coupled with styles and layout in mind because there are blocks that just change attributes and nothing else visually, like the embed block.

Related issue: #25231

@gziolo
Copy link
Member Author

gziolo commented Oct 23, 2020

I think we can close it in favor of #25231 that is covering exactly the same topic.

@gziolo gziolo closed this as completed Oct 23, 2020
@gziolo gziolo added [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed and removed Needs Dev Ready for, and needs developer efforts labels Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Feature] Block API API that allows to express the block paradigm. [Feature] Inspector Controls The interface showing block settings and the controls available for each block [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

4 participants