Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format Library: Link popup positioned incorrectly (Safari?) #20250

Open
Tracked by #35073
aduth opened this issue Feb 14, 2020 · 3 comments
Open
Tracked by #35073

Format Library: Link popup positioned incorrectly (Safari?) #20250

aduth opened this issue Feb 14, 2020 · 3 comments
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Package] Format library /packages/format-library [Type] Bug An existing feature does not function as intended

Comments

@aduth
Copy link
Member

aduth commented Feb 14, 2020

Reported by @gziolo in #20052

From #20052 (comment) :

when opening the link popover from the block toolbar, the popover is placed in the position relative to the toolbar rather than the selected text, it would be also great to keep the indicator for the selected text

From #20052 (comment) :

Steps to reproduce:

  1. Enter Edit mode in the text block.
  2. Selects text with arrow keys + shift.
  3. Press shift + tab until focus reaches the block toolbar.
  4. Use the right arrow key to focus the link button
  5. Press enter or space to launch the link popover
  6. Observe whether the link is positioned correctly.

Note: I have not yet been able to reproduce this.

@aduth aduth added [Type] Bug An existing feature does not function as intended Browser Issues Issues or PRs that are related to browser specific problems Needs Testing Needs further testing to be confirmed. [Package] Format library /packages/format-library [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) labels Feb 14, 2020
@gziolo
Copy link
Member

gziolo commented Feb 15, 2020

Browser: Safari
OS: macOS

@talldan
Copy link
Contributor

talldan commented Jun 11, 2020

I was able to reproduce something similar, though the popover if positioned some way below the block:
Screenshot 2020-06-11 at 1 47 45 pm

It looks like text selection is lost when shift-tabbing to the toolbar, but the link does still apply ok.

I've updated the steps in the description as the process has now changed.

@talldan talldan removed the Needs Testing Needs further testing to be confirmed. label Jun 11, 2020
@torounit
Copy link
Member

https://support.apple.com/guide/safari/keyboard-and-other-shortcuts-cpsh003/mac

Press shift + tab until focus reaches the block toolbar.

Depending on Safari settings, Press shift + option + tab instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Browser Issues Issues or PRs that are related to browser specific problems [Feature] Link Editing Link components (LinkControl, URLInput) and integrations (RichText link formatting) [Package] Format library /packages/format-library [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

4 participants