Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Navigation block: add style variations #18552

Closed
karmatosed opened this issue Nov 15, 2019 · 1 comment
Closed

Navigation block: add style variations #18552

karmatosed opened this issue Nov 15, 2019 · 1 comment
Assignees
@karmatosed
Labels
[Block] Navigation Affects the Navigation Block

Comments

@karmatosed
Copy link
Member

karmatosed commented Nov 15, 2019 •
edited
Loading

I am going to work on a PR for this but a good idea to get an issue to hook into. This builds on from #18491 and will have:

  • Light style with arrow
  • Dark style with arrow

This does depend on #18466 being resolved.
@karmatosed karmatosed self-assigned this Nov 15, 2019
@karmatosed karmatosed added the [Block] Navigation Affects the Navigation Block label Nov 15, 2019
karmatosed pushed a commit that referenced this issue Nov 15, 2019
Adds in default style variation
b1e3f61 
Start of fixing #18552
@karmatosed karmatosed mentioned this issue Nov 15, 2019
Merged
2 tasks
noisysocks pushed a commit that referenced this issue Nov 19, 2019
@noisysocks
Adds in default style variation
bd758aa 
Start of fixing #18552
karmatosed pushed a commit that referenced this issue Nov 19, 2019
Adds in default style variation
3d82e6b 
Start of fixing #18552
youknowriad pushed a commit that referenced this issue Nov 22, 2019
@youknowriad
Adds in default style variation
d625b41 
Start of fixing #18552
@karmatosed
Copy link
Member Author

This should have closed with last commit so closing :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karmatosed karmatosed

Labels
[Block] Navigation Affects the Navigation Block
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@karmatosed