Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Top toolbar items unnecessarily buried on large screens #16889

Closed
iandunn opened this issue Aug 2, 2019 · 7 comments
Closed

Top toolbar items unnecessarily buried on large screens #16889

iandunn opened this issue Aug 2, 2019 · 7 comments
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Milestone

Comments

@iandunn
Copy link
Member

iandunn commented Aug 2, 2019

Problem

Some items in the top toolbar are hidden behind a dropdown menu, even when there is plenty of space to show them:

Screen Shot 2019-08-02 at 8 01 59 AM

This makes them harder to discover, and means that mouse users have to do an extra click every time they want to use those buttons.

Was that an intentional design decision to avoid overwhelming the user, or does the toolbar not adapt just because that feature wasn't part of the MVP?

Proposed Solution

When there's space for it, all of the toolbar's items should be shown. When there isn't, they should be automatically moved to dropdown menu, like they are today.

@iandunn iandunn added [Type] Enhancement A suggestion for improvement. General Interface Parts of the UI which don't fall neatly under other labels. Needs Design Feedback Needs general design feedback. labels Aug 2, 2019
@karmatosed
Copy link
Member

karmatosed commented Aug 5, 2019

My concern here is moving interaction elements because of screen size. I totally get on larger screens there is the space, but I don't think that means we should surface everything. I'd love for opinions here on if those icons are important enough to show on top level or belong in secondary under a drop down. For me, they are secondary enough for drop down and reduce cognitive load by being there.

@kjellr
Copy link
Contributor

kjellr commented Aug 5, 2019

I agree with @karmatosed on this one. In this particular case, the items in the dropdown aren't necessarily there only because they don't fit, but because they're less important used than the Bold/Italic/Link buttons. As another example, we also recently made the decision to hide all alignment toolbar items behind a dropdown for other reasons too.

For what it's worth though, it does look like Google auto-expands as the screen gets bigger:

docs

@mapk
Copy link
Contributor

mapk commented Aug 5, 2019

The example provided shows the Top Toolbar option enabled. In that particular case, one might have room to allow more icons to be surfaced. When moving these icons into dropdowns, I did not consider the Top Toolbar option. It might be worth revisiting this.

The best thing to help this move forward would be to list which icons/actions are the ones to be surfaced or develop a rule of some kind like "When there is room, begin from the left and expand each dropdown until there is no more room." I'm just throwing out ideas here.

@kjellr
Copy link
Contributor

kjellr commented Aug 5, 2019

The example provided shows the Top Toolbar option enabled.

That's true. This could be something that's only available in that mode.

@davewhitley
Copy link
Contributor

davewhitley commented Aug 6, 2019

Expanding to show hidden icons on bigger viewports seems like a good idea to me, as long as it's not a justification to add additional icons/buttons. (i.e. "There's room for more buttons here, so why don't we add x feature to the top toolbar?")

@karmatosed karmatosed added this to the Future milestone Aug 7, 2019
@davidshq
Copy link
Contributor

davidshq commented Nov 7, 2019

I understand not showing all the formatting buttons due to importance, but it would be nice to be able to surface some buttons if the user desired. e.g., someone may find x button something they use frequently, having to click on a dropdown every time (assuming no keyboard shortcut, or user is not aware of shortcut) gets tedious.

@mapk
Copy link
Contributor

mapk commented Nov 12, 2019

e.g., someone may find x button something they use frequently, having to click on a dropdown every time (assuming no keyboard shortcut, or user is not aware of shortcut) gets tedious.

I understand the concern here. It's a good point. But I'd rather make purposeful decisions and limit the options presented to a user. I believe we did this well here and suggest we keep the it this way right now, but consider showing them in the Top Toolbar.

@mapk mapk added Needs Dev Ready for, and needs developer efforts and removed Needs Design Feedback Needs general design feedback. labels Apr 7, 2020
@annezazu annezazu closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
General Interface Parts of the UI which don't fall neatly under other labels. Needs Dev Ready for, and needs developer efforts [Type] Enhancement A suggestion for improvement.
Projects
None yet
Development

No branches or pull requests

7 participants