-
Notifications
You must be signed in to change notification settings - Fork 4.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Spec out which blocks need which controls #16
Comments
From #core-editor slack by @mcsf:
Seems prudent to keep this in mind for reusability as we spec out blocks. Particularly important, perhaps, for plugins that add blocks. F.ex. if a plugin adds a "checklist" block, they might apply traits such as |
Traits seem great on theory, but they worry me a bit too much it can add a lot of complexity for both users and plugin makers. Maybe a v2 thing? Maybe I just worry too much about complexity increase? |
Let's spec out some more blocks. This is very brainstormy and speculative at this point. Code/Gist Base properties:
Advanced properties:
List, ordered, unordered Base properties:
Gallery Base properties:
Advanced properties:
Generic embed Base properties:
Advanced properties:
Map Base properties:
Advanced properties:
Separator Base properties:
Advanced properties:
Tweet (and variations) Base properties:
Advanced properties:
Video (YouTube, Vimeo, etc.) Base properties:
Advanced properties:
Audio Base properties:
Advanced properties:
Contact Form/Survey Base properties:
Advanced properties:
Table of Contents Base properties:
WP Post embed Base properties:
Advanced properties:
Facebook embed Base properties:
Advanced properties:
Link Block Basically a "any unidentified URL pasted" block, basically what all messaging platforms do when you paste a link, turn it into stylish link plus preview, using all the metadata Facebook got everyone to put in. Base properties:
Advanced properties:
Playlist Base properties:
Poet Block Alternate version of "preformatted" without the monospaced font, respects spaces (inserts
Custom Field Base properties:
Advanced properties:
|
A few notes and ideas about contextual menu approaches (and data architecture of the actions/options) |
I took the list and turned in a spreadsheet for ease of editing and reviewing. Comments should be open: |
I feel excited that I found this list. I will work on turning it into a design asset guide in sketch for quick design mockups. Fellow designers might find it handy to throw out quick ideas on element positioning or even UI styles. I would start something similar in any case, but it's great that we can all align with a common reference like this one. |
This PR intends to add all blocks on #16 to the inserter, so we can get a feel for how the UI works when it has lots of blocks. It isn't yet functional. @youknowriad do you have any idea why? Thanks
Another block idea. Perhaps not for launch, but noting for later on: File Download Base properties: Basic alignments |
@jasmussen I have been thinking about this pasting inside the block itself behaviour and was considering the default state of a freshly added block as an input context. At the current editor, when you click to add a media, you are prompted to select your media file via the popup. Are we looking to offer a similar -perhaps more simplified- flow but from within the editor block? Apologies if there has already been a discussion about a different approach and i haven't notice. Isn't this useful for the case of a spotify playlist block and any custom block that may require a basic setup? |
Probably some of the answers will present themselves as we start working. But this is probably one of the aspects where we can remove many modals. Image and gallery both are probably the most important ones to get right. One dream instance is that you drag an image from your desktop into the editor, and that's it — that's your image block. Same for galleries, except you're dragging multiple images. What happens when you drag an image onto another image block? Does it become a gallery? (Wouldn't it be cool if it did?) And yes, if you click the inserter, click the image, then you should probably get a placeholder just like your mockup. But do we show a button to let you pick the image(s?) from your media library? Or do we show your media library right there? Similarly if you insert an image block using the "commandline" (See #24), then ideally you should be able to pick the image you want using arrow keys and enter. Lots of fine interactions to tune here! |
Thanks a lot, this is great. Lots of juice here indeed. |
Here are a bunch of individual block mockups, showing controls. Image Text Heading Embed Code/Gist Quote Gallery Much of the UI is being discussed elsewhere also. In the case of the gallery, this is an early draft showing something that would be wonderful to be able to do — insert text in one of the spots where images would otherwise be. Lots of UI to still h hammer out here — how much can you configure the gallery? Can you select amount of columns? How do you insert text? Hopefully by sharing early we can tackle these challenges together. |
The gallery will become an interesting block. I like being able to add text, and if we go this far, should we maybe allow more things like video? What should and should not be allowed? |
Actually I think I'm going to pull back a little for V1 so we can ship it on time :D That is, upgrade and polish the current gallery with 1:1 features. Then we can ensure that the block API and plugin-hooks can ensure we can build a killer "anything-gallery" as a quick block right after. |
For the code/gist block, it'd be slick to optionally paste some code or paste a link to a github gist. Also, I'm not sure if the alignments would be needed for code blocks, for example, is there a case when code should be centered? |
Excellent point. I was thinking if you were authoring a really richly layouted post, you might want a "wider than the main column" view. But yeah it's probably good to not include the alignments in that one until they become strictly necessary. |
Should we close this issue? |
Yep, good call. There's still value here, but we can dig it up from the archive if we need it. Much of it is obsolete. Thanks Riad. |
…ommand-readme Update readme: add missing install command + warning early stage
…rce-view [Android] Remove source view
…otation Added rule: `selector-pseudo-element-colon-notation`
F.ex. Headline won't need bold/italic inline controls, and Image might need some extra alignment controls, such as "full bleed". Let's start spec'ing out the most basic blocks, get those right, then we can add to it.
Text, or Paragraph
Base properties:
Advanced properties:
Heading
Base properties:
Advanced properties:
Quote
Base properties:
cite
attributeAdvanced properties:
Image
Base properties:
Advanced properties:
img
todiv
with background?)The text was updated successfully, but these errors were encountered: