Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting column elements is very difficult/confusing #15975

Closed
iandunn opened this issue Jun 3, 2019 · 2 comments
Closed

Selecting column elements is very difficult/confusing #15975

iandunn opened this issue Jun 3, 2019 · 2 comments
Labels
[Block] Columns Affects the Columns Block Needs Design Needs design efforts. [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended

Comments

@iandunn
Copy link
Member

iandunn commented Jun 3, 2019

From #9156

Selecting elements (especially the RIGHT element) is very confusing.

Base styles should probably include a gutter between columns.

Being able to select the individual columns maybe isn't strictly necessary. The only thing you can do with them is add a CSS class. Why not just add a CSS class to begin with?

When the block is first inserted, there are no borders around the columns, so it's not obvious what the block even does until you insert content into both columns. Even after you insert content, it's difficult to click on the Column (singular) and Columns (plural) containers, because they have no borders to help you distinguish between them and their children; they probably also don't have much (if any) padding. The only way I could reliably access them was through the Block Navigator component.

I'm not sure if removing the UI of the Column (singular) block is possible at this point b/c of back-compat, but maybe it could be done for blocks that don't have a custom CSS class assigned yet?

Related #11159

@iandunn iandunn added [Type] Bug An existing feature does not function as intended Needs Design Needs design efforts. [Block] Columns Affects the Columns Block labels Jun 3, 2019
@sarahmonster sarahmonster mentioned this issue Jun 3, 2019
11 tasks
@talldan
Copy link
Contributor

talldan commented Jun 4, 2019

Hi @iandunn - there's a very similar issue open at the moment:

And there are some PRs attempting to tackle this:

I think this one could be considered a duplicate of #9268, so will close it. Let me know if you disagree.

I'm not sure if removing the UI of the Column (singular) block is possible at this point b/c of back-compat, but maybe it could be done for blocks that don't have a custom CSS class assigned yet?

I remember seeing some past discussion on #14961, I think recently there have been some additional features added to the column (vertical alignment, column width), which might make that less of a possibility.

@talldan talldan added the [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed label Jun 4, 2019
@talldan talldan closed this as completed Jun 4, 2019
@iandunn
Copy link
Member Author

iandunn commented Jun 5, 2019

👍 I missed those in my search, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Columns Affects the Columns Block Needs Design Needs design efforts. [Status] Duplicate Used to indicate that a current issue matches an existing one and can be closed [Type] Bug An existing feature does not function as intended
Projects
None yet
Development

No branches or pull requests

2 participants