Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group Block: add ability to alter padding values #14747

Closed
getdave opened this issue Apr 1, 2019 · 6 comments · Fixed by #24966
Closed

Group Block: add ability to alter padding values #14747

getdave opened this issue Apr 1, 2019 · 6 comments · Fixed by #24966
Assignees
Labels
[Block] Group Affects the Group Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.

Comments

@getdave
Copy link
Contributor

getdave commented Apr 1, 2019

The Section Block currently has padding added when a background color is set. It would be good to be able to adjust this setting regardless of whether there is a background color set.

Describe the solution you'd like
A UI to enable the adjusting of the Block inner padding. This should

  • Allow pixel level adjustment of the Block padding
  • Allow adjustment of the 4 values independently of each other or as a single value

Potential Considerations

  • What should happen with different viewport sizes? For exmaple a large padding that looks great on large screens would look terrible on small screens. How do we handle this?
@getdave getdave added the [Block] Group Affects the Group Block label Apr 1, 2019
@youknowriad
Copy link
Contributor

I think there's already an issue about this (related to responsive controls), this might be a duplicate.

@youknowriad youknowriad added the [Type] Enhancement A suggestion for improvement. label Apr 22, 2019
@youknowriad youknowriad changed the title Section Block - add ability to alter padding values Group Block - add ability to alter padding values Apr 22, 2019
@paaljoachim
Copy link
Contributor

I would think that the Group block could go ahead as an example on how to add block specific padding/margin controls. Getting it in place so that down the line it could also be added to other blocks.

I am adding in some issues.

Block-specific responsive controls
#13363

Add padding and margin for blocks, and get rid of Spacer block.
#11824

Add Block: Responsive
#6650

Support for Responsive Columns
#6048

@mtias mtias added the Needs Design Needs design efforts. label Jun 26, 2019
@mtias
Copy link
Member

mtias commented Jun 26, 2019

I like starting with this block to see how specific controls might work.

@mtias mtias changed the title Group Block - add ability to alter padding values Group Block: add ability to alter padding values Jun 26, 2019
@getdave getdave self-assigned this Jun 27, 2019
@getdave
Copy link
Contributor Author

getdave commented Jul 25, 2019

@mtias I've started work on an implementation of this.

@mapk
Copy link
Contributor

mapk commented Dec 27, 2019

I'm removing the Needs Design label because it looks like the design work in happening in the PR.

@mapk mapk removed the Needs Design Needs design efforts. label Dec 27, 2019
@mtias mtias added the [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi label Aug 30, 2020
@mtias
Copy link
Member

mtias commented Aug 30, 2020

@ItsJonQ could we look at enabling the padding control from Cover here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Block] Group Affects the Group Block [Feature] Design Tools Tools that impact the appearance of blocks both to expand the number of tools and improve the experi [Status] In Progress Tracking issues with work in progress [Type] Enhancement A suggestion for improvement.
Projects
None yet
5 participants