Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleting empty text area not possible without adding text into area #10334

Closed
gingerling opened this issue Oct 4, 2018 · 4 comments
Closed
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).

Comments

@gingerling
Copy link

gingerling commented Oct 4, 2018

Describe the bug
I have mobility issues and keep accidentally clicking the plus icon at the top of a block, which inserts and new empty block above. There is no way to then delete this new block. The only way I have found is to put text (just a random letter) in the block which makes the menu pop up, so I can click the three dots and then remove the block.

It's a small thing in manyways, however, building one page I did this about 10 times and it was extremely annoying/frustrating.

To Reproduce
Steps to reproduce the behavior:

  1. Create a block, add text to it.
  2. Click on the block then click the plus icon at the centre top of the block - a new, empty block appears.
  3. Try to remove the block.
  4. Type a letter, it appears in the block - you can now remove the block using the menu for the block.

Expected behavior
Simple x or similar, to be able to remove an empty block. Should be one click.

Screenshots
If applicable, add screenshots to help explain your problem.

https://greencloud.gn.apc.org/index.php/s/SDo3PeMeDJ6zwFX

https://greencloud.gn.apc.org/index.php/s/LHCQxHdwCBxbdJ2

https://greencloud.gn.apc.org/index.php/s/LHCQxHdwCBxbdJ2

https://greencloud.gn.apc.org/index.php/s/waws8MkX7fscsXC

Desktop (please complete the following information):

  • OS: [e.g. iOS] fedora linux
  • Browser [e.g. chrome, safari] firefox
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22] 3.9.0
@tofumatt tofumatt added the [Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes). label Oct 4, 2018
@aaronjorbin aaronjorbin added this to the WordPress 5.0 milestone Oct 11, 2018
@kkoppenhaver
Copy link
Contributor

One way I've been thinking about this would be to put a delete icon in the inserter that shows up when the block has no content.

screen shot 2018-10-13 at 6 01 49 pm

screen shot 2018-10-13 at 6 02 57 pm

Would be interested in hearing some thoughts on this approach or possible alternatives. Once we decide, I can likely tackle this in the next couple days.

@gingerling
Copy link
Author

gingerling commented Oct 16, 2018 via email

@StaggerLeee
Copy link

I agree there shoud be dashicon trash icon there. Planty of space, even in mobile.

@aduth
Copy link
Member

aduth commented Oct 31, 2018

The in-between inserter no longer automatically creates a paragraph block. As of #11018, it now shows the default inserter menu. As such, it's my understanding this issue would no longer be relevant? Let me know if it is and it can be reopened.

@aduth aduth closed this as completed Oct 31, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Accessibility (a11y) Changes that impact accessibility and need corresponding review (e.g. markup changes).
Projects
None yet
Development

No branches or pull requests

6 participants