Components: Fix logic of has-text class addition in Button (#56949)

* Components: Remove fixed width for `compact` sized Buttons * update changelog * Fix logic of has-text class addition in Button * fix changelog
WordPress · Dec 14, 2023 · fbc1188 · fbc1188 · github-actions · Dec 14, 2023
1 parent 053a8aa
commit fbc1188
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/packages/components/CHANGELOG.md b/packages/components/CHANGELOG.md
@@ -6,6 +6,10 @@
 
 -   `TabPanel`: do not render hidden content ([#57046](https://github.com/WordPress/gutenberg/pull/57046)).
 
+### Bug Fix
+
+-   `Button`: Fix logic of `has-text` class addition ([#56949](https://github.com/WordPress/gutenberg/pull/56949)).
+
 ## 25.14.0 (2023-12-13)
 
 ### Enhancements

diff --git a/packages/components/src/button/index.tsx b/packages/components/src/button/index.tsx
@@ -156,7 +156,7 @@ export function UnforwardedButton(
 		'is-busy': isBusy,
 		'is-link': variant === 'link',
 		'is-destructive': isDestructive,
-		'has-text': !! icon && hasChildren,
+		'has-text': !! icon && ( hasChildren || text ),
 		'has-icon': !! icon,
 	} );