Skip to content

Commit

Permalink
Blocks: Render Button RichText as div (#8451)
Browse files Browse the repository at this point in the history
* Blocks: Render Button RichText as div

* Blocks: Update Button block snapshot per changed element
  • Loading branch information
aduth committed Aug 8, 2018
1 parent ee6060f commit fb15328
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 4 deletions.
1 change: 0 additions & 1 deletion core-blocks/button/edit.js
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ class ButtonEdit extends Component {
<Fragment>
<span className={ className } title={ title } ref={ this.bindRef }>
<RichText
tagName="span"
placeholder={ __( 'Add text…' ) }
value={ text }
onChange={ ( value ) => setAttributes( { text: value } ) }
Expand Down
6 changes: 3 additions & 3 deletions core-blocks/button/test/__snapshots__/index.js.snap
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ exports[`core/button block edit matches snapshot 1`] = `
<div
class="components-autocomplete"
>
<span
<div
aria-autocomplete="list"
aria-expanded="false"
aria-label="Add text…"
Expand All @@ -24,11 +24,11 @@ exports[`core/button block edit matches snapshot 1`] = `
data-is-placeholder-visible="true"
role="textbox"
/>
<span
<div
class="editor-rich-text__tinymce wp-block-button__link"
>
Add text…
</span>
</div>
</div>
</div>
</div>
Expand Down

0 comments on commit fb15328

Please sign in to comment.