Editor: Ignore save edits in undo history.

WordPress · Sep 16, 2019 · e8f75f7 · e8f75f7
1 parent b0606f7
commit e8f75f7
Show file tree

Hide file tree

Showing 2 changed files with 22 additions and 4 deletions.
diff --git a/packages/e2e-tests/specs/undo.test.js b/packages/e2e-tests/specs/undo.test.js
@@ -109,6 +109,15 @@ describe( 'undo', () => {
 		expect( visibleContent ).toBe( 'original' );
 	} );
 
+	it( 'should not create undo levels when saving', async () => {
+		await clickBlockAppender();
+		await page.keyboard.type( '1' );
+		await saveDraft();
+		await pressKeyWithModifier( 'primary', 'z' );
+
+		expect( await getEditedPostContent() ).toBe( '' );
+	} );
+
 	it( 'should immediately create an undo level on typing', async () => {
 		await clickBlockAppender();
 

diff --git a/packages/editor/src/store/actions.js b/packages/editor/src/store/actions.js
@@ -348,13 +348,22 @@ export function setupEditorState( post ) {
  * Returns an action object used in signalling that attributes of the post have
  * been edited.
  *
- * @param {Object} edits Post attributes to edit.
+ * @param {Object}  edits      Post attributes to edit.
+ * @param {boolean} undoIgnore Whether to ignore the edit in undo history or not.
  *
  * @yield {Object} Action object or control.
  */
-export function* editPost( edits ) {
+export function* editPost( edits, undoIgnore ) {
 	const { id, type } = yield select( STORE_KEY, 'getCurrentPost' );
-	yield dispatch( 'core', 'editEntityRecord', 'postType', type, id, edits );
+	yield dispatch(
+		'core',
+		'editEntityRecord',
+		'postType',
+		type,
+		id,
+		edits,
+		undoIgnore
+	);
 }
 
 /**
@@ -385,7 +394,7 @@ export function* savePost( options = {} ) {
 		content: yield select( STORE_KEY, 'getEditedPostContent' ),
 	};
 	if ( ! options.isAutosave ) {
-		yield dispatch( STORE_KEY, 'editPost', edits );
+		yield dispatch( STORE_KEY, 'editPost', edits, true );
 	}
 
 	yield __experimentalRequestPostUpdateStart( options );