Fix: Packages\Url: Trim leading and trailing whitespaces (#17320)

* Fix: Packages\Url: Trim leading and trailing whitespaces * Added unit tests for prependHTTP()
WordPress · Sep 4, 2019 · e420ac2 · e420ac2
1 parent 0e55ef6
commit e420ac2
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/packages/url/src/index.js b/packages/url/src/index.js
@@ -360,6 +360,7 @@ export function removeQueryArgs( url, ...args ) {
  * @return {string} The updated URL.
  */
 export function prependHTTP( url ) {
+	url = url.trim();
 	if ( ! USABLE_HREF_REGEXP.test( url ) && ! EMAIL_REGEXP.test( url ) ) {
 		return 'http://' + url;
 	}

diff --git a/packages/url/src/test/index.test.js b/packages/url/src/test/index.test.js
@@ -496,6 +496,18 @@ describe( 'prependHTTP', () => {
 
 		expect( prependHTTP( url ) ).toBe( url );
 	} );
+
+	it( 'should remove leading whitespace before prepending HTTP', () => {
+		const url = ' wordpress.org';
+
+		expect( prependHTTP( url ) ).toBe( 'http://wordpress.org' );
+	} );
+
+	it( 'should not have trailing whitespaces', () => {
+		const url = 'wordpress.org ';
+
+		expect( prependHTTP( url ) ).toBe( 'http://wordpress.org' );
+	} );
 } );
 
 describe( 'safeDecodeURI', () => {