Add eslint rules to guard against unexpected imports/exports (#28513)

* Add eslint-plugin-import and enable default and named rules * Fix the rest errors * Update changelog * Warn it first to prevent breaking change * Add eslint-plugin-import to root devDeps * Fix code reviews
WordPress · Feb 1, 2021 · d63f9a1 · d63f9a1
1 parent d9e7541
commit d63f9a1
Show file tree

Hide file tree

Showing 7 changed files with 19 additions and 7 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -54,6 +54,8 @@ module.exports = {
 			},
 		],
 		'@wordpress/no-unsafe-wp-apis': 'off',
+		'import/default': 'error',
+		'import/named': 'error',
 		'no-restricted-imports': [
 			'error',
 			{
@@ -152,6 +154,7 @@ module.exports = {
 			rules: {
 				'import/no-extraneous-dependencies': 'off',
 				'import/no-unresolved': 'off',
+				'import/named': 'off',
 			},
 		},
 		{

diff --git a/package-lock.json b/package-lock.json
diff --git a/package.json b/package.json
@@ -158,6 +158,7 @@
 		"enzyme": "3.11.0",
 		"equivalent-key-map": "0.2.2",
 		"eslint-plugin-eslint-comments": "3.1.2",
+		"eslint-plugin-import": "2.22.1",
 		"execa": "4.0.2",
 		"fast-glob": "2.2.7",
 		"glob": "7.1.2",

diff --git a/packages/block-editor/src/store/test/actions.js b/packages/block-editor/src/store/test/actions.js
@@ -21,7 +21,10 @@ import {
 
 import * as selectors from '../selectors';
 import reducer from '../reducer';
-import actions, {
+import * as actions from '../actions';
+import '../..';
+
+const {
 	clearSelectedBlock,
 	enterFormattedText,
 	exitFormattedText,
@@ -55,8 +58,7 @@ import actions, {
 	updateSettings,
 	selectionChange,
 	validateBlocksToTemplate,
-} from '../actions';
-import '../..';
+} = actions;
 
 describe( 'actions', () => {
 	const defaultBlockSettings = {

diff --git a/packages/components/src/form-token-field/test/lib/token-field-wrapper.js b/packages/components/src/form-token-field/test/lib/token-field-wrapper.js
@@ -52,4 +52,4 @@ class TokenFieldWrapper extends Component {
 	}
 }
 
-module.exports = TokenFieldWrapper;
+export default TokenFieldWrapper;
diff --git a/packages/eslint-plugin/CHANGELOG.md b/packages/eslint-plugin/CHANGELOG.md
@@ -2,6 +2,10 @@
 
 ## Unreleased
 
+### New Features
+
+-   Enabled `import/default` and `import/named` rules in the `recommended` ruleset. [#28513](https://github.com/WordPress/gutenberg/pull/28513)
+
 ## 8.0.1 (2021-01-28)
 
 ### Bug Fix

diff --git a/packages/eslint-plugin/configs/recommended-with-formatting.js b/packages/eslint-plugin/configs/recommended-with-formatting.js
@@ -24,6 +24,8 @@ module.exports = {
 			},
 		],
 		'import/no-unresolved': 'error',
+		'import/default': 'warn',
+		'import/named': 'warn',
 	},
 	overrides: [
 		{
-Original file line number
+Diff line change
@@ Expand Up / @@ -52,4 +52,4 @@ class TokenFieldWrapper extends Component { @@
     	}
     }
-    module.exports = TokenFieldWrapper;
+    export default TokenFieldWrapper;