Skip to content

Commit

Permalink
Update the layout of the title in the top bar while template editing (#…
Browse files Browse the repository at this point in the history
…27845)

Co-authored-by: Shaun Andrews <shaun@automattic.com>
  • Loading branch information
jameskoster and shaunandrews authored Jan 13, 2021
1 parent fc5e799 commit d0d6bfa
Show file tree
Hide file tree
Showing 3 changed files with 51 additions and 35 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -204,7 +204,7 @@ describe( 'Multi-entity editor states', () => {
// Our custom template shows up in the " templates > all" menu; let's use it.
await clickTemplateItem( [ 'Templates', 'All' ], templateName );
await page.waitForXPath(
`//p[contains(@class, "edit-site-document-actions__title") and contains(text(), '${ templateName }')]`
`//h1[contains(@class, "edit-site-document-actions__title") and contains(text(), '${ templateName }')]`
);

removeErrorMocks();
Expand Down
39 changes: 23 additions & 16 deletions packages/edit-site/src/components/header/document-actions/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -90,21 +90,34 @@ export default function DocumentActions( {
ref={ titleRef }
className="edit-site-document-actions__title-wrapper"
>
<h1>
<VisuallyHidden>
<Text
variant="body.small"
className="edit-site-document-actions__title-prefix"
>
<VisuallyHidden as="span">
{ sprintf(
/* translators: %s: the entity being edited, like "template"*/
__( 'Edit %s:' ),
__( 'Editing %s:' ),
entityLabel
) }
</VisuallyHidden>
<Text
variant="subtitle.small"
className="edit-site-document-actions__title"
>
{ entityTitle }
</Text>
</h1>
</Text>

<Text
variant="body.small"
className="edit-site-document-actions__title"
as="h1"
>
{ entityTitle }
</Text>

<Text
variant="body.small"
className="edit-site-document-actions__secondary-item"
>
{ label ?? '' }
</Text>

{ dropdownContent && (
<Dropdown
popoverProps={ {
Expand All @@ -130,12 +143,6 @@ export default function DocumentActions( {
/>
) }
</div>
<Text
variant="body"
className="edit-site-document-actions__secondary-item"
>
{ label ?? '' }
</Text>
</div>
);
}
Original file line number Diff line number Diff line change
Expand Up @@ -14,20 +14,22 @@
flex-direction: row;
justify-content: center;
align-items: center;
transition: transform 0.2s;
@include reduce-motion(transition);

// See comment above about min-width
min-width: 0;

// Since part of the dropdown button width is blank space, visually,
// it looks off-center. This offsets that blank space.
margin-left: 12px;
.components-dropdown {
display: inline-flex;
margin-left: $grid-unit-05;

.components-button {
min-width: 0;
padding: 0;
}
}
}

.edit-site-document-actions__title-wrapper > h1 {
display: flex;
justify-content: center;
margin: 0;

// See comment above about min-width
Expand All @@ -38,29 +40,36 @@
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
max-width: 120px;

@include break-medium() {
max-width: 75px;
}

@include break-xlarge() {
max-width: 180px;
}
}

.edit-site-document-actions__secondary-item {
opacity: 0;
transform: translateY(0);
transition: transform 0.2s;
white-space: nowrap;
overflow: hidden;
text-overflow: ellipsis;
text-align: center;
max-width: 0;
opacity: 0;
padding: 0;
transition: all ease 0.2s;
background: $gray-200;
border-radius: 2px;
@include reduce-motion(transition);
}

&.has-secondary-label {
transform: translateY(10px);

.edit-site-document-actions__title-wrapper {
transform: translateY(-12px);
}

.edit-site-document-actions__secondary-item {
opacity: 1;
transform: translateY(-16px);
padding: 0 4px;
max-width: 180px;
margin-left: 6px;
}
}
}
Expand Down

0 comments on commit d0d6bfa

Please sign in to comment.