-
Notifications
You must be signed in to change notification settings - Fork 4.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Site Editor: Wrap each router area in 'ErrorBoundary' (#64245)
* Use the error boundary from the `editor` package in the Site Editor. * Update the `ErrorBoundary` markup and remove the `Warning` component. It still matches the design. * Update letter casing for button labels. * Change "Copy post text" to "Copy contents" and make the action label more general. * Make the "Copy contents" action opt-in. * Use the primary button variant for "Copy error". Co-authored-by: Mamaduka <mamaduka@git.wordpress.org> Co-authored-by: youknowriad <youknowriad@git.wordpress.org> Co-authored-by: jasmussen <joen@git.wordpress.org>
- Loading branch information
1 parent
6b16c73
commit b8bfb4d
Showing
7 changed files
with
43 additions
and
137 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
40 changes: 0 additions & 40 deletions
40
packages/edit-site/src/components/error-boundary/test/error-boundary.js
This file was deleted.
Oops, something went wrong.
30 changes: 0 additions & 30 deletions
30
packages/edit-site/src/components/error-boundary/warning.js
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,7 +1,11 @@ | ||
.editor-error-boundary { | ||
font-family: $default-font; | ||
margin: auto; | ||
max-width: 780px; | ||
padding: 20px; | ||
padding: 1em; | ||
margin-top: 60px; | ||
box-shadow: $elevation-large; | ||
border: $border-width solid $gray-900; | ||
border-radius: $radius-small; | ||
background-color: $white; | ||
} |
b8bfb4d
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Flaky tests detected in b8bfb4d.
Some tests passed with failed attempts. The failures may not be related to this commit but are still reported for visibility. See the documentation for more information.
🔍 Workflow run URL: https://github.com/WordPress/gutenberg/actions/runs/12196089297
📝 Reported issues:
/test/e2e/specs/editor/blocks/navigation-frontend-interactivity.spec.js