Skip to content

Commit

Permalink
ToggleGroupControl: fix unselected icon color (#44575)
Browse files Browse the repository at this point in the history
* ToggleGroupControl: fix unselected icon
color

* CHANGELOG

* Snapshots
  • Loading branch information
ciampo authored Sep 29, 2022
1 parent 3ae203c commit b06eac0
Show file tree
Hide file tree
Showing 3 changed files with 11 additions and 7 deletions.
1 change: 1 addition & 0 deletions packages/components/CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@

- `Popover`: fix limitShift logic by adding iframe offset correctly [#42950](https://github.com/WordPress/gutenberg/pull/42950)).
- `Popover`: refine position-to-placement conversion logic, add tests ([#44377](https://github.com/WordPress/gutenberg/pull/44377)).
- `ToggleGroupControl`: adjust icon color when inactive, from `gray-700` to `gray-900` ([#44575](https://github.com/WordPress/gutenberg/pull/44575)).
- `TokenInput`: improve logic around the `aria-activedescendant` attribute, which was causing unintended focus behavior for some screen readers ([#44526](https://github.com/WordPress/gutenberg/pull/44526)).

### Internal
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -159,6 +159,7 @@ exports[`ToggleGroupControl should render correctly with icons 1`] = `
}
.emotion-15 {
color: #1e1e1e;
width: 30px;
padding-left: 0;
padding-right: 0;
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -55,13 +55,6 @@ export const buttonView = css`
}
`;

export const buttonActive = css`
color: ${ COLORS.white };
&:active {
background: transparent;
}
`;

export const ButtonContentView = styled.div`
font-size: ${ CONFIG.fontSize };
line-height: 1;
Expand All @@ -82,8 +75,17 @@ export const isIcon = ( {
};

return css`
color: ${ COLORS.gray[ 900 ] };
width: ${ iconButtonSizes[ size ] };
padding-left: 0;
padding-right: 0;
`;
};

export const buttonActive = css`
color: ${ COLORS.white };
&:active {
background: transparent;
}
`;

0 comments on commit b06eac0

Please sign in to comment.