Fix error with defaultColumnsNumber when attributes.ids is not set

Make InnerBlocks self closing in save method
WordPress · Oct 7, 2020 · adaee2c · adaee2c
1 parent 11a028c
commit adaee2c
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/packages/block-library/src/gallery/gallery.js b/packages/block-library/src/gallery/gallery.js
@@ -48,7 +48,7 @@ export const Gallery = ( props ) => {
 				__experimentalItemCallback={ ( item ) => (
 					<li className="wp-block-gallery__image">{ item }</li>
 				) }
-			></InnerBlocks>
+			/>
 
 			{ mediaPlaceholder }
 			<RichTextVisibilityHelper

diff --git a/packages/block-library/src/gallery/shared.js b/packages/block-library/src/gallery/shared.js
@@ -4,7 +4,7 @@
 import { get, pick } from 'lodash';
 
 export function defaultColumnsNumber( attributes ) {
-	return Math.min( 3, attributes.ids.length );
+	return attributes?.ids?.length ? Math.min( 3, attributes.ids.length ) : 3;
 }
 
 export const pickRelevantMediaFiles = ( image, sizeSlug = 'large' ) => {