Site Logo: Remove unnecessary 'block-editor' store subscription (#57513)

WordPress · Jan 3, 2024 · a142fa4 · a142fa4
1 parent bc0cfc6
commit a142fa4
Showing 1 changed file with 3 additions and 4 deletions.
diff --git a/packages/block-library/src/site-logo/edit.js b/packages/block-library/src/site-logo/edit.js
@@ -412,7 +412,6 @@ export default function LogoEdit( {
 		siteIconId,
 		mediaItemData,
 		isRequestingMediaItem,
-		mediaUpload,
 	} = useSelect( ( select ) => {
 		const { canUser, getEntityRecord, getEditedEntityRecord } =
 			select( coreStore );
@@ -444,9 +443,9 @@ export default function LogoEdit( {
 			mediaItemData: mediaItem,
 			isRequestingMediaItem: _isRequestingMediaItem,
 			siteIconId: _siteIconId,
-			mediaUpload: select( blockEditorStore ).getSettings().mediaUpload,
 		};
 	}, [] );
+	const { getSettings } = useSelect( blockEditorStore );
 
 	const { editEntityRecord } = useDispatch( coreStore );
 
@@ -511,8 +510,8 @@ export default function LogoEdit( {
 	};
 
 	const onFilesDrop = ( filesList ) => {
-		mediaUpload( {
-			allowedTypes: [ 'image' ],
+		getSettings().mediaUpload( {
+			allowedTypes: ALLOWED_MEDIA_TYPES,
 			filesList,
 			onFileChange( [ image ] ) {
 				if ( isBlobURL( image?.url ) ) {