API Fetch: Fix error on empty OPTIONS preload data (#14714)

WordPress · Mar 30, 2019 · 8d8a285 · 8d8a285
1 parent 580fedd
commit 8d8a285
Show file tree

Hide file tree

Showing 2 changed files with 27 additions and 14 deletions.
diff --git a/packages/api-fetch/src/middlewares/preloading.js b/packages/api-fetch/src/middlewares/preloading.js
@@ -34,7 +34,11 @@ const createPreloadingMiddleware = ( preloadedData ) => ( options, next ) => {
 
 		if ( parse && 'GET' === method && preloadedData[ path ] ) {
 			return Promise.resolve( preloadedData[ path ].body );
-		} else if ( 'OPTIONS' === method && preloadedData[ method ][ path ] ) {
+		} else if (
+			'OPTIONS' === method &&
+			preloadedData[ method ] &&
+			preloadedData[ method ][ path ]
+		) {
 			return Promise.resolve( preloadedData[ method ][ path ] );
 		}
 	}

diff --git a/packages/api-fetch/src/middlewares/test/preloading.js b/packages/api-fetch/src/middlewares/test/preloading.js
@@ -25,20 +25,29 @@ describe( 'Preloading Middleware', () => {
 		} );
 	} );
 
-	it( 'should move to the next middleware if no preloaded data', () => {
-		const preloadedData = {};
-		const prelooadingMiddleware = createPreloadingMiddleware( preloadedData );
-		const requestOptions = {
-			method: 'GET',
-			path: 'wp/v2/posts',
-		};
+	describe.each( [
+		[ 'GET' ],
+		[ 'OPTIONS' ],
+	] )( '%s', ( method ) => {
+		describe.each( [
+			[ 'all empty', {} ],
+			[ 'method empty', { [ method ]: {} } ],
+		] )( '%s', ( label, preloadedData ) => {
+			it( 'should move to the next middleware if no preloaded data', () => {
+				const prelooadingMiddleware = createPreloadingMiddleware( preloadedData );
+				const requestOptions = {
+					method,
+					path: 'wp/v2/posts',
+				};
 
-		const callback = ( options ) => {
-			expect( options ).toBe( requestOptions );
-			return true;
-		};
+				const callback = ( options ) => {
+					expect( options ).toBe( requestOptions );
+					return true;
+				};
 
-		const ret = prelooadingMiddleware( requestOptions, callback );
-		expect( ret ).toBe( true );
+				const ret = prelooadingMiddleware( requestOptions, callback );
+				expect( ret ).toBe( true );
+			} );
+		} );
 	} );
 } );