DRY up conditionals

Addresses #17846 (comment)
WordPress · Oct 29, 2019 · 8b0e864 · 8b0e864
1 parent f7eea8b
commit 8b0e864
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/packages/block-editor/src/components/url-input/index.js b/packages/block-editor/src/components/url-input/index.js
@@ -238,7 +238,9 @@ class URLInput extends Component {
 	static getDerivedStateFromProps( { value, disableSuggestions }, { showSuggestions, selectedSuggestion } ) {
 		let shouldShowSuggestions = showSuggestions;
 
-		if ( ! value || ! value.length ) {
+		const hasValue = value && value.length;
+
+		if ( ! hasValue ) {
 			shouldShowSuggestions = false;
 		}
 
@@ -247,7 +249,7 @@ class URLInput extends Component {
 		}
 
 		return {
-			selectedSuggestion: value && value.length ? selectedSuggestion : null,
+			selectedSuggestion: hasValue ? selectedSuggestion : null,
 			showSuggestions: shouldShowSuggestions,
 		};
 	}