Refactor edit to set the default value for download button label

WordPress · Apr 23, 2019 · 80e6f41 · 80e6f41
1 parent 61eebc9
commit 80e6f41
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 5 deletions.
diff --git a/packages/block-library/src/file/block.json b/packages/block-library/src/file/block.json
@@ -32,8 +32,7 @@
 		"downloadButtonText": {
 			"type": "string",
 			"source": "html",
-			"selector": "a[download]",
-			"default": "Download"
+			"selector": "a[download]"
 		}
 	}
 }
diff --git a/packages/block-library/src/file/edit.js b/packages/block-library/src/file/edit.js
@@ -29,7 +29,7 @@ import {
 } from '@wordpress/block-editor';
 import { mediaUpload } from '@wordpress/editor';
 import { Component, Fragment } from '@wordpress/element';
-import { __ } from '@wordpress/i18n';
+import { __, _x } from '@wordpress/i18n';
 
 /**
  * Internal dependencies
@@ -55,8 +55,8 @@ class FileEdit extends Component {
 	}
 
 	componentDidMount() {
-		const { attributes, noticeOperations } = this.props;
-		const { href } = attributes;
+		const { attributes, noticeOperations, setAttributes } = this.props;
+		const { downloadButtonText, href } = attributes;
 
 		// Upload a file drag-and-dropped into the editor
 		if ( isBlobURL( href ) ) {
@@ -73,6 +73,12 @@ class FileEdit extends Component {
 
 			revokeBlobURL( href );
 		}
+
+		if ( downloadButtonText === undefined ) {
+			setAttributes( {
+				downloadButtonText: _x( 'Download', 'button label' ),
+			} );
+		}
 	}
 
 	componentDidUpdate( prevProps ) {