move empty array out of useSelect, add empty dependency array

WordPress · Oct 25, 2024 · 7bcb7c0 · 7bcb7c0
1 parent 163068b
commit 7bcb7c0
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/packages/block-library/src/html/preview.js b/packages/block-library/src/html/preview.js
@@ -23,14 +23,15 @@ const DEFAULT_STYLES = `
 
 export default function HTMLEditPreview( { content, isSelected } ) {
 	const settingStyles = useSelect(
-		( select ) => select( blockEditorStore ).getSettings().styles || []
+		( select ) => select( blockEditorStore ).getSettings().styles,
+		[]
 	);
 
 	const styles = useMemo(
 		() => [
 			DEFAULT_STYLES,
 			...transformStyles(
-				settingStyles.filter( ( style ) => style.css )
+				( settingStyles ?? [] ).filter( ( style ) => style.css )
 			),
 		],
 		[ settingStyles ]