Paste: strip HTML formatting space for inline text (#19043)

WordPress · Dec 10, 2019 · 6ad16aa · 6ad16aa
1 parent 23f9795
commit 6ad16aa
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 0 deletions.
diff --git a/packages/blocks/src/api/raw-handling/paste-handler.js b/packages/blocks/src/api/raw-handling/paste-handler.js
@@ -50,6 +50,7 @@ const { console } = window;
 function filterInlineHTML( HTML ) {
 	HTML = deepFilterHTML( HTML, [ googleDocsUIDRemover, phrasingContentReducer, commentRemover ] );
 	HTML = removeInvalidHTML( HTML, getPhrasingContentSchema( 'paste' ), { inline: true } );
+	HTML = deepFilterHTML( HTML, [ htmlFormattingRemover, brRemover ] );
 
 	// Allows us to ask for this information when we get a report.
 	console.log( 'Processed inline HTML:\n\n', HTML );

diff --git a/test/integration/__snapshots__/blocks-raw-handling.test.js.snap b/test/integration/__snapshots__/blocks-raw-handling.test.js.snap
@@ -10,6 +10,8 @@ exports[`Blocks raw handling pasteHandler should remove extra blank lines 1`] =
 <!-- /wp:paragraph -->"
 `;
 
+exports[`Blocks raw handling pasteHandler should strip HTML formatting space from inline text 1`] = `"Lorem ipsum dolor sit amet, consectetur adipiscing elit. Praesent a elit eget tortor molestie egestas. Donec pretium urna vitae mattis imperdiet. Praesent et lorem iaculis, volutpat odio vitae, ornare lacus. Donec ut felis tristique, pharetra erat id, viverra justo. Integer sit amet elementum arcu, eget pharetra felis. In malesuada enim est, sed placerat nulla feugiat at. Vestibulum feugiat vitae elit sit amet tincidunt. Pellentesque finibus sed dolor non facilisis. Curabitur accumsan ante ac hendrerit vestibulum."`;
+
 exports[`Blocks raw handling pasteHandler should strip some text-level elements 1`] = `
 "<!-- wp:paragraph -->
 <p>This is ncorect</p>

diff --git a/test/integration/blocks-raw-handling.test.js b/test/integration/blocks-raw-handling.test.js
@@ -319,6 +319,12 @@ describe( 'Blocks raw handling', () => {
 			const HTML = readFile( path.join( __dirname, 'fixtures/windows.html' ) );
 			expect( serialize( pasteHandler( { HTML } ) ) ).toMatchSnapshot();
 		} );
+
+		it( 'should strip HTML formatting space from inline text', () => {
+			const HTML = readFile( path.join( __dirname, 'fixtures/inline-with-html-formatting-space.html' ) );
+			expect( pasteHandler( { HTML } ) ).toMatchSnapshot();
+			expect( console ).toHaveLogged();
+		} );
 	} );
 } );
 

diff --git a/test/integration/fixtures/inline-with-html-formatting-space.html b/test/integration/fixtures/inline-with-html-formatting-space.html
@@ -0,0 +1,11 @@
+<html><body>
+    <!--StartFragment-->Lorem ipsum dolor sit amet, consectetur adipiscing elit. Praesent a elit
+     eget tortor molestie egestas. Donec pretium urna vitae mattis
+    imperdiet. Praesent et lorem iaculis, volutpat odio vitae, ornare lacus.
+     Donec ut felis tristique, pharetra erat id, viverra justo. Integer sit
+    amet elementum arcu, eget pharetra felis. In malesuada enim est, sed
+    placerat nulla feugiat at. Vestibulum feugiat vitae elit sit amet
+    tincidunt. Pellentesque finibus sed dolor non facilisis. Curabitur
+    accumsan ante ac hendrerit vestibulum.
+    <!--EndFragment-->
+    </body>